A specific unit shouldn't be attached to a variable label #530
Labels
Comments
|
To solve this (without modifying the ontology) we are:
If we want to have unique tuples (variable, unit) linked to the model, we will need to modify the ontology and add something similar to parameters on the model level. |
hvarg
added a commit
that referenced
this issue
Mar 23, 2021
hvarg
added a commit
that referenced
this issue
Mar 23, 2021
* Hotfix: removing duplicate * Solving more Issues (#418) * Added category to full text search * Fixed models compare * Show fixed parameter on execution * Added link on sample resources * Added GA and small fixes (#419) * handle 404 * Loading inputs from firebase instead of model catalog * Allow removing fixed values on setups * Added google analytics * New remote sensing page * Get rid of a Typescript error * Added HAND executions for Ethiopia * Enabling model register (#431) * Fixed duplicated variable * Google Analitics and UI changes (#420) * Hotfix: removing duplicate * Solving more Issues (#418) * Added category to full text search * Fixed models compare * Show fixed parameter on execution * Added link on sample resources * Added GA and small fixes (#419) * handle 404 * Loading inputs from firebase instead of model catalog * Allow removing fixed values on setups * Added google analytics * New remote sensing page * Hotfix: typo and size of video * Hotfix: typo * Hotfix: Do no show setups for main regions * Updating emulators page (#429) * Emulators update (#430) * Fixed link on emulators * Enable model creation * Model/Version edition and Data transformation (#437) * Fixed data transformation edition, * Data transformations on input selection * Data transformations fix * Parameter types * Support for Model and softwareVersion creation and edition * PUT models temporal fix * Enviroments fix (#438) * yarn.lock * Diferent config file and example * removing old code * Updated npm -> yarn and changes on the config file * build-dev * Compare and model creation (#444) * Icon for models compare a change the way the URL is created * model edit button and author order hack * Fixing model creation * Compare (#445) Adding all the enviroments logic and travis update * Ui fixes (#446) * loading description for setups * new tree and edit fixes * UI fixes (#447) * fixed tree on models compare * Fixed edit-tree interactions * Fixed cancel on model creation * hotfix * Gql merge (#451) * Fixed duplicated variable * Google Analitics and UI changes (#420) * Hotfix: removing duplicate * Solving more Issues (#418) * Added category to full text search * Fixed models compare * Show fixed parameter on execution * Added link on sample resources * Added GA and small fixes (#419) * handle 404 * Loading inputs from firebase instead of model catalog * Allow removing fixed values on setups * Added google analytics * New remote sensing page * Hotfix: typo and size of video * Hotfix: typo * Hotfix: Do no show setups for main regions * Updating emulators page (#429) * Emulators update (#430) * Fixed link on emulators * Changes for graphql * Added emulator-tabs using graphql * Added emulator-tabs using graphql * Adding initial support for GraphQL : Emulators * yarn.lock * Diferent config file and example * removing old code * Updated npm -> yarn and changes on the config file * build-dev * GraphQL conversion continued + Refactoring * Bug fixes and initial region integration * Get region browsing to work. Add/Delete TODO * Refactoring task/thread editors out of problem-statement ui * deletion query fix * Improvements to adding thread/task + New table for execution summary * Work with new GraphQL schema * Changes for Backward compatibility * Style fixes * Refactoring Dataset to Dataslice + Dataset * Env2 (#439) * Model/Version edition and Data transformation (#437) * Fixed data transformation edition, * Data transformations on input selection * Data transformations fix * Parameter types * Support for Model and softwareVersion creation and edition * PUT models temporal fix * Enviroments fix (#438) * yarn.lock * Diferent config file and example * removing old code * Updated npm -> yarn and changes on the config file * build-dev * Env fix (#440) * change script build * Webpack build script * travis node * Fix: build location * Fix: change build directory name * Added different keys * added code url + added Hernan to contributors * Updates for changes to backend * Bugfixes with emulator * Fix for event-based task status * DEV AUTH DOMAIN * Pass variable through webpack * Update README.md * Deleting old stuff * Fix for model query for region * fix: add yarn.lock netlify requires it * Initial: Adding permissions + minor updates * Check Permissions within the thread * Initial permissions + Some fixes for ensemble manager interface Co-authored-by: Varun Ratnakar <varunratnakar@gmail.com> Co-authored-by: Maximiliano Osorio <maxiosorio@gmail.com> * Hotfix (#456) Hotfix: input files on model view. * added standard variables to numerical index (#458) * Gqlmerge (#459) * Initial: Adding permissions + minor updates * Check Permissions within the thread * Initial permissions + Some fixes for ensemble manager interface * Efficient Loading of executions in threads * Bugfixes * Simple permissions UI * Bugfix * Emulator Search Draft * Load executions as well as total in emulator search * Next/Previous for runs in emulator page Co-authored-by: Varun Ratnakar <varunratnakar@gmail.com> Co-authored-by: Maximiliano Osorio <maxiosorio@gmail.com> * Fix for emulator search for non-logins * bugfix * Load Variable Information from Backend * V1.6 (#465) * Fixed #432 * Partial fix for #461 * basic 1.6 * Hotfix: editable categories * Fix: GeoShape fail on PUT * Added month as time interval. Added logo to models. * Fix caching models from model catalog to graphql * Storing software image in cache too * tabs on emulators page * Fixed search models by index * Added * to indicatos on task form * Formative evaluation (#488) * fix #469 * Fix #487 * Fix #485 * Allow selection of multiple numerical index * Fix: #477 * Hackish fix #472 * Hide the Save Results button * Fix for execution subscriptions * check * small bugfix + re-enable analysis report subscriptions for now * Changed analysis reports to non-subscription calls, so they don't mess with the use models * Better fix for #466 * Default value as placeholder & model-indicator fixes * Fix for empty run screen sometimes * bugfix * Added a missing file * Do no show empty model type * Search index on lower case * Fix for dataset selection * Removing requirement for datasets * Put a check for start date being before end date * Fix for model selection based on subregion/region * Decoupling Reports-Analysis state from Modeling state * Support for legacy results where some flags are missing * Fix for Tabs not being selected properly * Add loading dots * compiling in production mode for dev too to reduce file size * Dont fetch execution summary with main thread * compiling in production mode * rollback * Reset executions/summaries on thread change * Removing sort by execution start time, to speed up queries * Move to next section on select & continue * Show indicators while adding task/thread * Fix #495 * Fix #505 * Some issues (#509) * Fix #500 * Optiona fix for: #502 * Fix: #455 * Fix: #507 * Fix: #506 * Small bugfix for runs tab sometimes not shown as done even though all runs are finished * Added run prefix * Autoselect dataset if some of their resources has been selected * Hide extra outputs as default * Added hover to model preview title * Improvement in re-editing threads * Fix the waiting status * Fix logs display dos newline * Add format while caching new models * Not querying fixed values for now, to make querying faster * Dont show fixed values in list of values * Open results in new window * Responsive UI * Edit setup fixes and improvements (#520) * Setup new template * Fix: #510 * Fix #480 , #479 & #481 * Update to v1.7 * Fixes for parameters and inputs * do no show loading when no versions * Show new config even when there's any config * Not lazy creation * Fixed loading forever when no setups * Now parameters and inputs can be removed * Fix lazy edition * Issues (#521) * Added unit UI * fixed lazy save on configs * Added message when positions are wrong * Added PIHM as label on indices * Enabled duplication for configuration and setups * Updated version number * Fixed: activate edit by url * Visual changes to model and editable type * urlify for citations * Fix #524 * Fix #525 * Fix: #526 * Fix error on config/setup creation * Updated ontology and partial fix for #527 * Added types for: #527 * New attributes added to model view and config/setup * New properties to model compare and changed order of input files * Added source code and interventions. * Added variables and processes to models * Fixed return value of get all models * Added input / output model variables to models view * Added QUIC Fire URB images * Small fixes * Fixed small issues * Fixed model types and added variables to comparison * show grant * Added units to variables * Added more main regions * Added API link * wildfire assets, notification for categories * Added rules for variable units * Fix uniq condition * Added description to variables for #530 Co-authored-by: Varun Ratnakar <varunratnakar@gmail.com> Co-authored-by: Maximiliano Osorio <maxiosorio@gmail.com>
mosoriob
added a commit
that referenced
this issue
Jun 10, 2021
* Fixed duplicated variable * Google Analitics and UI changes (#420) * Hotfix: removing duplicate * Solving more Issues (#418) * Added category to full text search * Fixed models compare * Show fixed parameter on execution * Added link on sample resources * Added GA and small fixes (#419) * handle 404 * Loading inputs from firebase instead of model catalog * Allow removing fixed values on setups * Added google analytics * New remote sensing page * Hotfix: typo and size of video * Hotfix: typo * Hotfix: Do no show setups for main regions * Updating emulators page (#429) * Emulators update (#430) * Fixed link on emulators * yarn.lock * WIP * Added drought emulator * Generic model-catalog redux API * Test * Update to model-catalog v1.7 (#531) * Hotfix: removing duplicate * Solving more Issues (#418) * Added category to full text search * Fixed models compare * Show fixed parameter on execution * Added link on sample resources * Added GA and small fixes (#419) * handle 404 * Loading inputs from firebase instead of model catalog * Allow removing fixed values on setups * Added google analytics * New remote sensing page * Get rid of a Typescript error * Added HAND executions for Ethiopia * Enabling model register (#431) * Fixed duplicated variable * Google Analitics and UI changes (#420) * Hotfix: removing duplicate * Solving more Issues (#418) * Added category to full text search * Fixed models compare * Show fixed parameter on execution * Added link on sample resources * Added GA and small fixes (#419) * handle 404 * Loading inputs from firebase instead of model catalog * Allow removing fixed values on setups * Added google analytics * New remote sensing page * Hotfix: typo and size of video * Hotfix: typo * Hotfix: Do no show setups for main regions * Updating emulators page (#429) * Emulators update (#430) * Fixed link on emulators * Enable model creation * Model/Version edition and Data transformation (#437) * Fixed data transformation edition, * Data transformations on input selection * Data transformations fix * Parameter types * Support for Model and softwareVersion creation and edition * PUT models temporal fix * Enviroments fix (#438) * yarn.lock * Diferent config file and example * removing old code * Updated npm -> yarn and changes on the config file * build-dev * Compare and model creation (#444) * Icon for models compare a change the way the URL is created * model edit button and author order hack * Fixing model creation * Compare (#445) Adding all the enviroments logic and travis update * Ui fixes (#446) * loading description for setups * new tree and edit fixes * UI fixes (#447) * fixed tree on models compare * Fixed edit-tree interactions * Fixed cancel on model creation * hotfix * Gql merge (#451) * Fixed duplicated variable * Google Analitics and UI changes (#420) * Hotfix: removing duplicate * Solving more Issues (#418) * Added category to full text search * Fixed models compare * Show fixed parameter on execution * Added link on sample resources * Added GA and small fixes (#419) * handle 404 * Loading inputs from firebase instead of model catalog * Allow removing fixed values on setups * Added google analytics * New remote sensing page * Hotfix: typo and size of video * Hotfix: typo * Hotfix: Do no show setups for main regions * Updating emulators page (#429) * Emulators update (#430) * Fixed link on emulators * Changes for graphql * Added emulator-tabs using graphql * Added emulator-tabs using graphql * Adding initial support for GraphQL : Emulators * yarn.lock * Diferent config file and example * removing old code * Updated npm -> yarn and changes on the config file * build-dev * GraphQL conversion continued + Refactoring * Bug fixes and initial region integration * Get region browsing to work. Add/Delete TODO * Refactoring task/thread editors out of problem-statement ui * deletion query fix * Improvements to adding thread/task + New table for execution summary * Work with new GraphQL schema * Changes for Backward compatibility * Style fixes * Refactoring Dataset to Dataslice + Dataset * Env2 (#439) * Model/Version edition and Data transformation (#437) * Fixed data transformation edition, * Data transformations on input selection * Data transformations fix * Parameter types * Support for Model and softwareVersion creation and edition * PUT models temporal fix * Enviroments fix (#438) * yarn.lock * Diferent config file and example * removing old code * Updated npm -> yarn and changes on the config file * build-dev * Env fix (#440) * change script build * Webpack build script * travis node * Fix: build location * Fix: change build directory name * Added different keys * added code url + added Hernan to contributors * Updates for changes to backend * Bugfixes with emulator * Fix for event-based task status * DEV AUTH DOMAIN * Pass variable through webpack * Update README.md * Deleting old stuff * Fix for model query for region * fix: add yarn.lock netlify requires it * Initial: Adding permissions + minor updates * Check Permissions within the thread * Initial permissions + Some fixes for ensemble manager interface Co-authored-by: Varun Ratnakar <varunratnakar@gmail.com> Co-authored-by: Maximiliano Osorio <maxiosorio@gmail.com> * Hotfix (#456) Hotfix: input files on model view. * added standard variables to numerical index (#458) * Gqlmerge (#459) * Initial: Adding permissions + minor updates * Check Permissions within the thread * Initial permissions + Some fixes for ensemble manager interface * Efficient Loading of executions in threads * Bugfixes * Simple permissions UI * Bugfix * Emulator Search Draft * Load executions as well as total in emulator search * Next/Previous for runs in emulator page Co-authored-by: Varun Ratnakar <varunratnakar@gmail.com> Co-authored-by: Maximiliano Osorio <maxiosorio@gmail.com> * Fix for emulator search for non-logins * bugfix * Load Variable Information from Backend * V1.6 (#465) * Fixed #432 * Partial fix for #461 * basic 1.6 * Hotfix: editable categories * Fix: GeoShape fail on PUT * Added month as time interval. Added logo to models. * Fix caching models from model catalog to graphql * Storing software image in cache too * tabs on emulators page * Fixed search models by index * Added * to indicatos on task form * Formative evaluation (#488) * fix #469 * Fix #487 * Fix #485 * Allow selection of multiple numerical index * Fix: #477 * Hackish fix #472 * Hide the Save Results button * Fix for execution subscriptions * check * small bugfix + re-enable analysis report subscriptions for now * Changed analysis reports to non-subscription calls, so they don't mess with the use models * Better fix for #466 * Default value as placeholder & model-indicator fixes * Fix for empty run screen sometimes * bugfix * Added a missing file * Do no show empty model type * Search index on lower case * Fix for dataset selection * Removing requirement for datasets * Put a check for start date being before end date * Fix for model selection based on subregion/region * Decoupling Reports-Analysis state from Modeling state * Support for legacy results where some flags are missing * Fix for Tabs not being selected properly * Add loading dots * compiling in production mode for dev too to reduce file size * Dont fetch execution summary with main thread * compiling in production mode * rollback * Reset executions/summaries on thread change * Removing sort by execution start time, to speed up queries * Move to next section on select & continue * Show indicators while adding task/thread * Fix #495 * Fix #505 * Some issues (#509) * Fix #500 * Optiona fix for: #502 * Fix: #455 * Fix: #507 * Fix: #506 * Small bugfix for runs tab sometimes not shown as done even though all runs are finished * Added run prefix * Autoselect dataset if some of their resources has been selected * Hide extra outputs as default * Added hover to model preview title * Improvement in re-editing threads * Fix the waiting status * Fix logs display dos newline * Add format while caching new models * Not querying fixed values for now, to make querying faster * Dont show fixed values in list of values * Open results in new window * Responsive UI * Edit setup fixes and improvements (#520) * Setup new template * Fix: #510 * Fix #480 , #479 & #481 * Update to v1.7 * Fixes for parameters and inputs * do no show loading when no versions * Show new config even when there's any config * Not lazy creation * Fixed loading forever when no setups * Now parameters and inputs can be removed * Fix lazy edition * Issues (#521) * Added unit UI * fixed lazy save on configs * Added message when positions are wrong * Added PIHM as label on indices * Enabled duplication for configuration and setups * Updated version number * Fixed: activate edit by url * Visual changes to model and editable type * urlify for citations * Fix #524 * Fix #525 * Fix: #526 * Fix error on config/setup creation * Updated ontology and partial fix for #527 * Added types for: #527 * New attributes added to model view and config/setup * New properties to model compare and changed order of input files * Added source code and interventions. * Added variables and processes to models * Fixed return value of get all models * Added input / output model variables to models view * Added QUIC Fire URB images * Small fixes * Fixed small issues * Fixed model types and added variables to comparison * show grant * Added units to variables * Added more main regions * Added API link * wildfire assets, notification for categories * Added rules for variable units * Fix uniq condition * Added description to variables for #530 Co-authored-by: Varun Ratnakar <varunratnakar@gmail.com> Co-authored-by: Maximiliano Osorio <maxiosorio@gmail.com> * Added info for #512 * Allow multiple catalogs, Custom model API * Example new API * Moving to new API part1 * Custom apis * model-catalog ui now uses new API * Moving to new API * Added custom queries * Fixing some custom queries * Create docker-publish.yml * Update docker-publish.yml * Update model catalog API * Publish Docker Image (#533) * fix: push dockerhub * fix: remove branch workflow * fix: github integration (#534) * force push * add common * fix: forcing * fix: add * force * fix: workflows * fix: use envs * fix: use large secret * fix: add exec mode * fix: add smaple * fix: add tacc deploy * fix: decrypt * fix: add exec permissions * fix: update config key * fix: typo * fix: upload new key * fix: reorder imports * fix: import preferences webpack * fix: pointing to graphql * fix: update graphql endpoint * Fix uploading maps * get details no redux * Removing old API references * missing file and remove comments * Fixed dependencies * Customizable endpoint from config.json * fix: gpg instructions * fix: decrypt_secret.sh * fix: remove travis * Configuration using files again 😛 (#536) * fix: github integration (#534) * force push * add common * fix: forcing * fix: add * force * fix: workflows * fix: use envs * fix: use large secret * fix: add exec mode * fix: add smaple * fix: add tacc deploy * fix: decrypt * fix: add exec permissions * fix: update config key * fix: typo * fix: upload new key * fix: reorder imports * fix: import preferences webpack * fix: pointing to graphql * fix: update graphql endpoint * Fix uploading maps * fix: gpg instructions * fix: decrypt_secret.sh * fix: remove travis Co-authored-by: Hernán Vargas <hern.var@gmail.com> * fix: using a unique script to deploy * update: gitignore * fix: use model catalog 8.0.0 * Keycloak adapter * removing firebase Co-authored-by: hvarg <hern.var@gmail.com> Co-authored-by: Varun Ratnakar <varunratnakar@gmail.com> Co-authored-by: Hernán Vargas <hvargas@MacBook-Air-de-Hernan.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Currently, the units are added as a variable description. However, the same variable can have two different units (e.g. temperature in degC and degF) and two different variables could share the same unit (eg. Water flux and heat flux). So we should treat them separately.
The text was updated successfully, but these errors were encountered: