Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color effects are applied to sprite even when OBJ window should disable them #3258

Open
Vulcalien opened this issue Jul 12, 2024 · 0 comments

Comments

@Vulcalien
Copy link

I've found a difference between hardware and mGBA.

In this test ROM, there are two sprites: 1. red square; 2. OBJ window. A color effect (brightness increase) is applied to all layers of the display.

Inside the OBJ window, color sprites are disabled. Outside, they are enabled.

On hardware, the red square is always drawn without applying the brightness increase, appearing fully red. Meanwhile, on mGBA the color effect is applied if the red square is OBJ 0 and the window is OBJ 1.

image

Expected behavior (same as hardware):
image

By pressing any button in the test ROM, the sprites are flipped, so that the window becomes OBJ 0 and the red square becomes OBJ 1. In that case, the behavior is accurate. I've not tested with different OBJ priorities, but I suspect that would yield some differences too.

Possibly #2809 is a result of the same underlying cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant