{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":698312627,"defaultBranch":"master","name":"noir","ownerLogin":"manastech","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-09-29T16:20:38.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1354950?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1723062719.0","currentOid":""},"activityList":{"items":[{"before":"5ef8e844059336c599aa8a3df131b4945e2e9cfe","after":"38b58e7082d0a65bc613e3368e8c6bfcdd1cba2f","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-08-09T21:15:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Remove stale TODO","shortMessageHtmlLink":"Remove stale TODO"}},{"before":"4364c48f3e3d6138b7da9879071427075453ae91","after":"5ef8e844059336c599aa8a3df131b4945e2e9cfe","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-08-09T20:45:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Document new \"debug test\" feature","shortMessageHtmlLink":"Document new \"debug test\" feature"}},{"before":"8d76cac187cf6620fd6f7f6fe2933091185bf812","after":"4364c48f3e3d6138b7da9879071427075453ae91","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-08-09T17:19:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Re-shape file_manager_and_file_from to build_workspace_file_manager\n\nnow it only returns a FileManager","shortMessageHtmlLink":"Re-shape file_manager_and_file_from to build_workspace_file_manager"}},{"before":"b70cd796d50a8dc95d366d3e6c680d3713e8197b","after":"8d76cac187cf6620fd6f7f6fe2933091185bf812","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-08-08T22:28:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Expand todo comment","shortMessageHtmlLink":"Expand todo comment"}},{"before":"2dc687c4cae09256de362fde0910b6f80dde390f","after":"b70cd796d50a8dc95d366d3e6c680d3713e8197b","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-08-08T22:18:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"remove execution_helpers auxiliary file","shortMessageHtmlLink":"remove execution_helpers auxiliary file"}},{"before":"7914726938115921e7b6b5357b3f5212a24f4569","after":"2dc687c4cae09256de362fde0910b6f80dde390f","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-08-08T22:07:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"simplify debu_test function","shortMessageHtmlLink":"simplify debu_test function"}},{"before":"ac3aa223cef73439961cd269d98f63bcc68ee9f5","after":"7914726938115921e7b6b5357b3f5212a24f4569","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-08-07T21:36:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"run cargo fmt","shortMessageHtmlLink":"run cargo fmt"}},{"before":"c36f131741ede7b0428fb302bfd561ee5e3ebc4f","after":"ac3aa223cef73439961cd269d98f63bcc68ee9f5","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-08-07T21:32:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"ignore clippy warnings since functions will be modified","shortMessageHtmlLink":"ignore clippy warnings since functions will be modified"}},{"before":null,"after":"eefd69b1d72a9f5cb2e7bbd3e554925a7670a2f3","ref":"refs/heads/feat/5208-debug-tests-repl-dap","pushedAt":"2024-08-07T20:31:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"feat: add some `Module` comptime functions (#5684)\n\n# Description\n\n## Problem\n\nPart of #5668\n\n## Summary\n\nAdds these comptime functions:\n- `Quoted::as_module`\n- `Module::name`\n- `Module::is_contract`\n- `Module::functions`\n- `FunctionDefinition::name`\n\n## Additional Context\n\nSome notes:\n- I made `Quoted::as_module` return `Option<ModuleId>`, while other\n`Quoted::as_...` methods currently return a non-Option instead.\nEventually it would be nice to unify these but doing that in this PR\nwould have made it much bigger and complex, mainly because those methods\nrely on methods that are used in many places in the compiler.\n- For now I made `Module::name` and `FunctionDefinition::name` return\n`Quoted`. Once we have a `String` type we could change them to `String`,\nand the logic from going to Quoted -> String is very simple.\n\nI was wondering... would a `String` type be what a Slice is for Arrays?\n\nOne more thought: I wonder if instead of returning `Option<ModuleId>` it\nwouldn't be better to return some kind of `Result`. That way the caller\nwould know what the error is, if it happens. But I think we don't have\n`Result` yet in Noir, right?\n\n## Documentation\\*\n\nCheck one:\n- [x] No documentation needed.\n- [ ] Documentation included in this PR.\n- [ ] **[For Experimental Features]** Documentation to be submitted in a\nseparate PR.\n\n# PR Checklist\\*\n\n- [x] I have tested the changes locally.\n- [x] I have formatted the changes with [Prettier](https://prettier.io/)\nand/or `cargo fmt` on default settings.\n\n---------\n\nCo-authored-by: jfecher <jake@aztecprotocol.com>","shortMessageHtmlLink":"feat: add some <code>Module</code> comptime functions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2450706896\" data-permission-text=\"Title is private\" data-url=\"https://github.com/noir-lang/noir/issues/5684\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/noir-lang/noir/pull/5684/hovercard\" href=\"https://github.com/noir-lang/noir/pull/5684\">noir-lang#5684</a>)"}},{"before":"3f354230b3dda85a8bf633b1cbe6d6875c43b698","after":"c36f131741ede7b0428fb302bfd561ee5e3ebc4f","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-08-07T20:30:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"fix compile error after rebase","shortMessageHtmlLink":"fix compile error after rebase"}},{"before":"c02a6f64b1920ec5a1a05e20df34227cc95d7b0a","after":"eefd69b1d72a9f5cb2e7bbd3e554925a7670a2f3","ref":"refs/heads/master","pushedAt":"2024-08-07T20:07:24.000Z","pushType":"push","commitsCount":48,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"feat: add some `Module` comptime functions (#5684)\n\n# Description\n\n## Problem\n\nPart of #5668\n\n## Summary\n\nAdds these comptime functions:\n- `Quoted::as_module`\n- `Module::name`\n- `Module::is_contract`\n- `Module::functions`\n- `FunctionDefinition::name`\n\n## Additional Context\n\nSome notes:\n- I made `Quoted::as_module` return `Option<ModuleId>`, while other\n`Quoted::as_...` methods currently return a non-Option instead.\nEventually it would be nice to unify these but doing that in this PR\nwould have made it much bigger and complex, mainly because those methods\nrely on methods that are used in many places in the compiler.\n- For now I made `Module::name` and `FunctionDefinition::name` return\n`Quoted`. Once we have a `String` type we could change them to `String`,\nand the logic from going to Quoted -> String is very simple.\n\nI was wondering... would a `String` type be what a Slice is for Arrays?\n\nOne more thought: I wonder if instead of returning `Option<ModuleId>` it\nwouldn't be better to return some kind of `Result`. That way the caller\nwould know what the error is, if it happens. But I think we don't have\n`Result` yet in Noir, right?\n\n## Documentation\\*\n\nCheck one:\n- [x] No documentation needed.\n- [ ] Documentation included in this PR.\n- [ ] **[For Experimental Features]** Documentation to be submitted in a\nseparate PR.\n\n# PR Checklist\\*\n\n- [x] I have tested the changes locally.\n- [x] I have formatted the changes with [Prettier](https://prettier.io/)\nand/or `cargo fmt` on default settings.\n\n---------\n\nCo-authored-by: jfecher <jake@aztecprotocol.com>","shortMessageHtmlLink":"feat: add some <code>Module</code> comptime functions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2450706896\" data-permission-text=\"Title is private\" data-url=\"https://github.com/noir-lang/noir/issues/5684\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/noir-lang/noir/pull/5684/hovercard\" href=\"https://github.com/noir-lang/noir/pull/5684\">noir-lang#5684</a>)"}},{"before":"ad4077d2d7beae24f97e7c2daa8408f9efd91d47","after":"3f354230b3dda85a8bf633b1cbe6d6875c43b698","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-08-07T20:00:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Notify if test passed or failed\n\n- add TestFunction to dap\n- add Abi dependency to debugger crate","shortMessageHtmlLink":"Notify if test passed or failed"}},{"before":"838918a3b565f1228e1cc2b1d68fe00fc3e0bded","after":"ad4077d2d7beae24f97e7c2daa8408f9efd91d47","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-29T21:50:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Remove unused imports","shortMessageHtmlLink":"Remove unused imports"}},{"before":"c3ec48bd7e8c273b6dfa47ab500eb90ceeb84298","after":"838918a3b565f1228e1cc2b1d68fe00fc3e0bded","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-29T21:46:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"extract common behavior for building FileManager and ParsedFiles","shortMessageHtmlLink":"extract common behavior for building FileManager and ParsedFiles"}},{"before":"db9cb9acc25b732039f9be7fc98bfdfd9174e1ee","after":"c3ec48bd7e8c273b6dfa47ab500eb90ceeb84298","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-29T19:23:10.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Compile test function for debugging if test_name is present","shortMessageHtmlLink":"Compile test function for debugging if test_name is present"}},{"before":"c7ddc5deef0d020e44b6d7d7697c1655cd3227cf","after":"db9cb9acc25b732039f9be7fc98bfdfd9174e1ee","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-26T20:38:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Remove debug println!","shortMessageHtmlLink":"Remove debug println!"}},{"before":"e30b347a0e26ee3de89307392caed01d601427be","after":"c02a6f64b1920ec5a1a05e20df34227cc95d7b0a","ref":"refs/heads/master","pushedAt":"2024-07-25T15:10:47.000Z","pushType":"push","commitsCount":44,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"fix: let trait calls work in globals (#5602)\n\n# Description\n\n## Problem\n\nResolves #5029\n\n## Summary\n\nTrait constraints weren't checked after elaborating a global.\n\n## Additional Context\n\nI couldn't just call `check_and_pop_function_context()` because that\nalso defaults type variables... and if we do that the usage of a global\nwill not have an effect on its type. I guess this is one scenario:\n\n```rust\nglobal x = 1; // What's the type of x?\n```\n\nWe don't know. I guess it ends up being `Field` later on (where?) But if\nwe have this:\n\n```rust\nglobal x = 1;\n\nfn main() {\n  let y: i32 = 0;\n  assert_eq(x, y);\n}\n```\n\nnow x's type will be `i32` because of that comparison. So if we eagerly\nbind `1` to its default type, this will break.\n\nAll of this to say: in Rust a global's type (well, for a `const`) must\nbe explicitly specified. I guess that if we also did that in Noir then\nthis wouldn't be a problem. And given that globals are, well, global, it\nmight be strange to have `global x = 1` expecting that to be a Field,\nused as a Field in many places, but you accidentally compare it to an\n`i32` and the type changes under the hood. But that's a bigger\ndiscussion, so maybe the fix in this PR is good for now?\n\n## Documentation\\*\n\nCheck one:\n- [x] No documentation needed.\n- [ ] Documentation included in this PR.\n- [ ] **[For Experimental Features]** Documentation to be submitted in a\nseparate PR.\n\n# PR Checklist\\*\n\n- [x] I have tested the changes locally.\n- [x] I have formatted the changes with [Prettier](https://prettier.io/)\nand/or `cargo fmt` on default settings.","shortMessageHtmlLink":"fix: let trait calls work in globals (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2428105805\" data-permission-text=\"Title is private\" data-url=\"https://github.com/noir-lang/noir/issues/5602\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/noir-lang/noir/pull/5602/hovercard\" href=\"https://github.com/noir-lang/noir/pull/5602\">noir-lang#5602</a>)"}},{"before":"d30594127965d1f9771e80b9a388b2850935da38","after":"c7ddc5deef0d020e44b6d7d7697c1655cd3227cf","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-24T23:12:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Remove debug println!","shortMessageHtmlLink":"Remove debug println!"}},{"before":"df5c5d9f27b538706a7fee7bf61ae009c8e00584","after":"d30594127965d1f9771e80b9a388b2850935da38","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-24T22:15:27.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Map opcode resulution erros in debugger as in executor","shortMessageHtmlLink":"Map opcode resulution erros in debugger as in executor"}},{"before":"f169e259d3b9809f4001659739c73299c51f47da","after":"df5c5d9f27b538706a7fee7bf61ae009c8e00584","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-16T22:32:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"remove unnecessary mut","shortMessageHtmlLink":"remove unnecessary mut"}},{"before":"82c84b9f495bcea3acfaf77f0db1095d7afb7327","after":"f169e259d3b9809f4001659739c73299c51f47da","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-16T22:29:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Expose errors when the debugger execution finishes","shortMessageHtmlLink":"Expose errors when the debugger execution finishes"}},{"before":"5ad5fa1fee9e72df29c9806f4b9f7af2b54d6d28","after":"82c84b9f495bcea3acfaf77f0db1095d7afb7327","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-16T20:36:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"[skip-ci] failing compilation","shortMessageHtmlLink":"[skip-ci] failing compilation"}},{"before":"223f2df359895c6ce51bedf12d3e93c6826793ee","after":"5ad5fa1fee9e72df29c9806f4b9f7af2b54d6d28","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-16T20:36:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"wip: register last seen error in debugger context\n\nwe need this to return the error from the debugger as a NargoError for\nvalidatin the tests","shortMessageHtmlLink":"wip: register last seen error in debugger context"}},{"before":"aee48b92f32eb2f00731e1e52bfd64e357364577","after":"a550536a32e91a2fd8a84b841cd42a7b0ca51b53","ref":"refs/heads/fix/debugger-brillig-assertion-fail","pushedAt":"2024-07-16T17:38:07.000Z","pushType":"push","commitsCount":50,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Merge branch 'master' into fix/debugger-brillig-assertion-fail","shortMessageHtmlLink":"Merge branch 'master' into fix/debugger-brillig-assertion-fail"}},{"before":"141ecddf79b27244a52097577395c7b41cd4d331","after":"e30b347a0e26ee3de89307392caed01d601427be","ref":"refs/heads/master","pushedAt":"2024-07-16T17:35:20.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"chore: Remove `--use-legacy` and resolution code (#5248)\n\n# Description\n\n## Problem\\*\n\n## Summary\\*\n\nMade this PR as an experiment to see how much legacy code we can remove\ntoday.\n\nIt looks like we can remove the majority of resolution code at the\n`dc_crate` level, but we can't remove the NameResolver or TypeChecker\nsince these are used by the aztec macros crate. This is something we'll\nhave to watch out for when the elaborator is used by default - that code\ninjected by macros will still use the old resolution & type checking\ncode. I'm not aware of any compatibility errors when running both but it\nis something to keep in mind.\n\nEdit: Removed the NameResolver and TypeChecker in a separate PR:\nhttps://github.com/noir-lang/noir/pull/5525\n\n## Additional Context\n\n## Documentation\\*\n\nCheck one:\n- [x] No documentation needed.\n- [ ] Documentation included in this PR.\n- [ ] **[For Experimental Features]** Documentation to be submitted in a\nseparate PR.\n\n# PR Checklist\\*\n\n- [x] I have tested the changes locally.\n- [x] I have formatted the changes with [Prettier](https://prettier.io/)\nand/or `cargo fmt` on default settings.","shortMessageHtmlLink":"chore: Remove <code>--use-legacy</code> and resolution code (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2351699141\" data-permission-text=\"Title is private\" data-url=\"https://github.com/noir-lang/noir/issues/5248\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/noir-lang/noir/pull/5248/hovercard\" href=\"https://github.com/noir-lang/noir/pull/5248\">noir-lang#5248</a>)"}},{"before":"afd20fdf4d18ee4888442a7319dd9abe7f0c881f","after":"223f2df359895c6ce51bedf12d3e93c6826793ee","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-12T19:37:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"wip: evaluate test status from debugger result","shortMessageHtmlLink":"wip: evaluate test status from debugger result"}},{"before":"13f337fbf818df65d1d0f033a5c6ee8e761de5bf","after":"afd20fdf4d18ee4888442a7319dd9abe7f0c881f","ref":"refs/heads/feat/5208-debug-tests","pushedAt":"2024-07-12T17:35:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"wip: extract common behavior","shortMessageHtmlLink":"wip: extract common behavior"}},{"before":"05982709903fd4cd8b07cc74e01ef674a3f4bd20","after":"b32db853fe5571f0b02e441320efc16290f67c24","ref":"refs/heads/feat/debug-repl-add-breakpoint","pushedAt":"2024-07-12T17:01:44.000Z","pushType":"push","commitsCount":35,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"Merge branch 'master' into feat/debug-repl-add-breakpoint","shortMessageHtmlLink":"Merge branch 'master' into feat/debug-repl-add-breakpoint"}},{"before":"299703cf4b87a84257f48f059eb58135ad36265d","after":"141ecddf79b27244a52097577395c7b41cd4d331","ref":"refs/heads/master","pushedAt":"2024-07-12T16:11:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"feat: skip reading values immediately after it being written into an array (#5449)\n\n# Description\n\n## Problem\\*\n\nResolves <!-- Link to GitHub Issue -->\n\n## Summary\\*\n\nI noticed a couple of cases where we were writing into an array and then\nimmediately reading the same index from it. This seems like something\nthat we should be able to unwind.\n\nDraft as I want to do more thinking on how `EnableSideEffects` can\ninteract with this.\n\n## Additional Context\n\n\n\n## Documentation\\*\n\nCheck one:\n- [x] No documentation needed.\n- [ ] Documentation included in this PR.\n- [ ] **[For Experimental Features]** Documentation to be submitted in a\nseparate PR.\n\n# PR Checklist\\*\n\n- [x] I have tested the changes locally.\n- [x] I have formatted the changes with [Prettier](https://prettier.io/)\nand/or `cargo fmt` on default settings.","shortMessageHtmlLink":"feat: skip reading values immediately after it being written into an …"}},{"before":"a33cafcb7e175ad8b3b80b8c9419a32e009ec702","after":"299703cf4b87a84257f48f059eb58135ad36265d","ref":"refs/heads/master","pushedAt":"2024-07-12T16:03:01.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"anaPerezGhiglia","name":"Ana Perez Ghiglia","path":"/anaPerezGhiglia","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13237343?s=80&v=4"},"commit":{"message":"fix: Don't type error when calling certain trait impls in the interpreter (#5471)\n\n# Description\n\n## Problem\\*\n\nResolves https://github.com/noir-lang/noir/issues/5428\n\n## Summary\\*\n\nThe interpreter was calling into `perform_impl_bindings` in more cases\nthan the monomorphizer.\nWhere the former calls into it for every trait impl method, the later\nonly calls into it for methods called from a `TraitMethodExpr` or\n`ImplKind::TraitMethod` on an ident/operator.\nIt seemed more correct to call into this function in all cases so I\nremoved the bug by also replacing NamedGenerics in the trait itself with\nbindable type variables.\n\n## Additional Context\n\nI've moved around some methods in `hir_def/types.rs` so that we don't\nhave 3 separate `impl Type {`s in the one file. The only two changes in\nthat file are the addition of\n`replace_named_generics_with_type_variables` and the formatting change\nfor debugging NamedGenerics.\n\n## Documentation\\*\n\nCheck one:\n- [x] No documentation needed.\n- [ ] Documentation included in this PR.\n- [ ] **[For Experimental Features]** Documentation to be submitted in a\nseparate PR.\n\n# PR Checklist\\*\n\n- [x] I have tested the changes locally.\n- [x] I have formatted the changes with [Prettier](https://prettier.io/)\nand/or `cargo fmt` on default settings.","shortMessageHtmlLink":"fix: Don't type error when calling certain trait impls in the interpr…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAElqT3vAA","startCursor":null,"endCursor":null}},"title":"Activity · manastech/noir"}