scandir_recrusive edge cases

[loqusion]

scandir_recursive is used to find shader files in one's shader directory. It has various issues that will probably only occur for less than 0.1% of users:

• It should find and return files higher up the directory tree first via breadth-first search, but instead it does a reverse pre-order depth-first search. This can have various performance and resource usage implications in niche situations.
• It doesn't properly handle cases where a symlink to a directory higher in the tree (e.g. a node is its own ancestor) causes an infinite loop which only breaks due to max_depth.

hyprshade/src/hyprshade/utils.py

Lines 19 to 34 in b6de0db

	def scandir_recursive(
	path: GenericPath[AnyStr], *, max_depth: int
	) -> Iterator[os.DirEntry[AnyStr]]:
	assert max_depth >= 0
	dir_stack = []
	with os.scandir(path) as it:
	for direntry in it:
	if not direntry.is_dir():
	yield direntry
	elif max_depth > 0:
	dir_stack.append(direntry)
	while dir_stack:
	yield from scandir_recursive(dir_stack.pop(), max_depth=max_depth - 1)