RFE: Fail if listener hasn't started because of github action type.

[rafaeldtinoco]

Describe the feature or problem you’d like to solve

When running listen.dev action in any workflow, if the method isn't supported (like a manual trigger, for example), it should fail the run so the user knows it is not working (instead of failing silently and not showing anything in the dashboard).

Proposed solution

I spent sometime trying to figure out why the detections were not happening in the manual triggering. Then I opened the listen steps and saw that message. I didn't think there was a problem as there wasn't a failure.

Additional context

N/A.

[leodido]

This is because the initial reporter (the comment one) could only work on pull requests:

lstn/pkg/reporter/factory/factory.go

Line 87 in 3a7bcc7

if !env.IsGitHubPullRequest() {

Since the pro reporter (the one that writes to https://dashboard.listen.dev) can also work on other events (for example on push GitHub events) we could think of removing this check here (1)

lstn/pkg/reporter/factory/factory.go

Line 63 in 3a7bcc7

if info.IsGitHubPullRequest() {

Of course, by doing so, we accept that this will work only when the https://github.com/listendev/action gets ci: only input.

In fact, with ci: true both reporters run (the gh-pull-comment AND the pro). In this case, the gh-pull-comment will error, causing the action to error.

A possible solution (2), in this last case, could be to detect that the gh-pull-comment is running together with the pro reporter and in this case, force the CLI to not fail/error.

Anyways, I would start implementing (1) for now.

WDYT

[leodido]

A (3) third solution, would be like you propose.

If the action cannot run on the current GitHub event, let it fail blocking the CI workflow of the user/customer.

But this was something that - in the past - I was explicitly asked not to let happen because it was causing friction to users/customers.

[rafaeldtinoco]

I like making it work in all cases because then testing Argus will be super easy, its just a click in a well known and existing workflow within the repo. So, I'm +1 for that IF possible/feasible.

THanks a lot for all the feedback.

[leodido]

Storing here another check we would need to remove:

https://github.com/listendev/lstn/blob/3a7bcc785b931a8c5a3f2adc93a75e96878e45ca/cmd/ci/ci.go#L104C8-L104C12