Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Errors in pink box in Submitted Data view do not match table view #2702

Open
hknahal opened this issue Aug 21, 2023 · 0 comments
Open
Labels
bug Something isn't working submitted data page

Comments

@hknahal
Copy link

hknahal commented Aug 21, 2023

Describe the bug

Downloaded error report TSV file from "Submitted Data" view does not match errors reported in pink box.

Steps To Reproduce

Link to view Treatment data in "Submitted Data" view in TEST-CA program on Staging: https://platform.staging.icgc-argo.org/submission/program/TEST-CA/clinical-data?donorId=&tab=treatment

Steps to reproduce the behaviour:

  1. Errors in pink box are not consistent with table view. Examples:
  • Error reported in pink box indicate 17 errors. However the # of Affected Records column in the table does not equal 17 though
  • Errors reported for 'treatment_type' values that do not exist in table view
  • Not all errors are highlighted in pink in the table.
    treatment_errors
  1. Change pagination to 100 rows. Errors reported in pink box do not update correctly and do not match what is seen in table.

Expected behaviour

  • Expect errors in pink box to reflect Submitted Data view.
  • Errors should update when # of rows are changed in table.
  • Expect the sum of # of Affected Rows in pink box in Submitted Data view to match the top line in the pink box (ie. "X error(s) found on the current page of treatment table").
@hknahal hknahal added the bug Something isn't working label Aug 21, 2023
@hknahal hknahal transferred this issue from icgc-argo/argo-clinical Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working submitted data page
Projects
None yet
Development

No branches or pull requests

1 participant