Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: aiohttp vs. gRPC API #625

Open
keunhong opened this issue May 31, 2024 · 1 comment
Open

Question: aiohttp vs. gRPC API #625

keunhong opened this issue May 31, 2024 · 1 comment

Comments

@keunhong
Copy link
Contributor

Hello! I was curious if there was a reason gcsfs uses aiohttp with the JSON API to query GCS rather than using the Google Python client which calls the gRPC API. AFAIK the gRPC API is a lot more efficient.

@martindurant
Copy link
Member

I don't think grpc-async was a thing when this repo switched to async.

Honestly, I doubt for the size of the encoded messages, it makes any difference at all, and actually json is pretty well optimized for python (whereas protobufs are certainly not). Any bytes payload (i.e., file down/uploads) would be the same in either model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants