Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix development and tests for Ruby 2.4 #42

Closed
georgiana-b opened this issue Aug 1, 2017 · 4 comments
Closed

Fix development and tests for Ruby 2.4 #42

georgiana-b opened this issue Aug 1, 2017 · 4 comments
Labels
contribute enhancement

Comments

@georgiana-b
Copy link
Contributor

Currently datapackage raises an error when installed on Ruby 2.4.1.
@roll roll added this to the Version-1 milestone Aug 2, 2017
@roll roll added the current label Aug 2, 2017
@georgiana-b
Copy link
Contributor Author

This depends on the new FakeWeb release which, according to chrisk/fakeweb#57 is coming soon.

@roll roll removed this from the Version-1 milestone Aug 9, 2017
@roll roll removed the current label Aug 9, 2017
@roll roll changed the title Add support for Ruby 2.4 Fix development and tets for Ruby 2.4 Aug 27, 2017
@roll roll changed the title Fix development and tets for Ruby 2.4 Fix development and tests for Ruby 2.4 Aug 27, 2017
@pmackay
Copy link

pmackay commented Feb 16, 2019

There hasnt yet been a new release of fakeweb. What do others think about migrating to use webmock instead, which has more regular support?

@switzersc
Copy link
Contributor

Hey y'all! User of the gem here and in the process of installing it locally to develop on it (at which point I ran into this issue). Just want to +1 the suggestion to move to webmock. =]

@roll roll added the contribute label Oct 2, 2019
@roll
Copy link
Member

roll commented Oct 7, 2019

Merging into #53

@roll roll closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribute enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pmackay @roll @switzersc @georgiana-b