From 4921420c7e22620dde05c4dcac2e76dbc15ae0fd Mon Sep 17 00:00:00 2001 From: Krzysztof Kirsz Date: Tue, 13 Feb 2024 15:03:27 +0100 Subject: [PATCH] cleanup unneccessary test case list; fix variable naming --- node/find_test.go | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/node/find_test.go b/node/find_test.go index 0b87685..2367ee2 100644 --- a/node/find_test.go +++ b/node/find_test.go @@ -166,8 +166,8 @@ func TestFindPathIntoListItemContainer(t *testing.T) { "fruits=apple/boat", } for _, test := range tests { - root := node.NewBrowser(m, nodeutil.ReflectChild(root)).Root() - target, err := root.Find(test) + browser := node.NewBrowser(m, nodeutil.ReflectChild(root)).Root() + target, err := browser.Find(test) fc.RequireEqual(t, nil, err) fc.AssertEqual(t, true, target != nil, "Could not find target "+test) } @@ -175,15 +175,10 @@ func TestFindPathIntoListItemContainer(t *testing.T) { func TestFindPathInsideEmptyList(t *testing.T) { m, root := LoadPathTestData() - tests := []string{ - "fruits=pear/origin/country", - } - for _, test := range tests { - root := node.NewBrowser(m, nodeutil.ReflectChild(root)).Root() - target, err := root.Find(test) - fc.RequireEqual(t, nil, err) - fc.AssertEqual(t, true, target == nil, "Target should not be found"+test) - } + browser := node.NewBrowser(m, nodeutil.ReflectChild(root)).Root() + target, err := browser.Find("fruits=pear/origin/country") + fc.RequireEqual(t, nil, err) + fc.AssertEqual(t, true, target == nil, "Target should not be found (fruits=pear/origin/country)") } func LoadPathTestData() (*meta.Module, map[string]interface{}) {