Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage is not consistent #280

Closed
fohrloop opened this issue May 9, 2024 · 1 comment
Closed

Code coverage is not consistent #280

fohrloop opened this issue May 9, 2024 · 1 comment
Assignees
Labels
Type: Maintenance Code quality, updating dependencies, pipelines, ...
Milestone

Comments

@fohrloop
Copy link
Owner

fohrloop commented May 9, 2024

For some reason I'm getting 100% code coverage locally (on Ubuntu) when working with #278 but the GitHub Actions pipelines give lower code coverage.

  • 1 line missing on linux
  • 7 lines missing on mac
  • no lines missing on windows

See: https://github.com/fohrloop/wakepy/actions/runs/9019169791/job/24781473430?pr=278

Task:

  • Figure out why the code coverage is not same in pipelines and when running tox (or invoke test) locally
  • Check that branch coverage is used everywhere (and not line coverage)
@fohrloop fohrloop self-assigned this May 9, 2024
@fohrloop fohrloop added the Type: Maintenance Code quality, updating dependencies, pipelines, ... label May 9, 2024
@fohrloop fohrloop added this to the wakepy 0.8.0 milestone May 9, 2024
@fohrloop
Copy link
Owner Author

fohrloop commented May 9, 2024

Hmm. Seems that the one line missing in linux tests was actually due to a failing test. The tests should probably just exclude some lines on mac. I don't think this is an issue after all. I'll close this and reopen if it's not easily fixed within #278.

@fohrloop fohrloop closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Code quality, updating dependencies, pipelines, ...
Projects
None yet
Development

No branches or pull requests

1 participant