Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot Viewer: Transform Buttons into icons, and reposition #333

Open
valentin-krasontovitsch opened this issue Jul 25, 2022 · 1 comment
Open
Labels
blocked good first issue Good for newcomers improvement Something nice to have, that will make life easier for developers or users or both.

Comments

@valentin-krasontovitsch
Copy link
Contributor

Cf. a discussion in the PR for rearranging the input fields - we are considering changing the buttons on the plot viewer for refreshing and collapsing / expanding the selectors into icons, and placing the icons somewhere where it's clearer that they are acting on all three input fields.

We have requested that an icon component be implemented in webviz-core-components, and this issue is blocked by that one (but that one should be done soon).

I am not sure where the icons should be placed - perhaps in some corner? My css-foo, in my experience, is sadly not very good with this, but perhaps a css wizard will come along and graciously pick up the task : )

The idea of hacking into dash or somehow hacking the webviz stack to inject javascript / css was shortly explored, but abandoned as too hacky.

I also thought about placing the icons in question in the sidebar for icons (currently upper right corner), but this turns out to not be the best idea, as

a) those icons become transparent unless the plugin is in hover state, and we might want our icons to be prominent at all times, and
b) there is a redesign well under way that will relocate the icon bar and limit the space available for any custom icons one might want to add there

@valentin-krasontovitsch valentin-krasontovitsch added good first issue Good for newcomers blocked improvement Something nice to have, that will make life easier for developers or users or both. labels Jul 25, 2022
@valentin-krasontovitsch
Copy link
Contributor Author

the component in question has been implemented! woopie! we can start playing with this, but we still have to wait for a new release of webviz-core-components to be cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked good first issue Good for newcomers improvement Something nice to have, that will make life easier for developers or users or both.
Projects
Status: No status
Development

No branches or pull requests

1 participant