Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension not working with latest chrome update. #2

Open
adcha17 opened this issue Feb 14, 2018 · 3 comments · May be fixed by #4
Open

Extension not working with latest chrome update. #2

adcha17 opened this issue Feb 14, 2018 · 3 comments · May be fixed by #4

Comments

@adcha17
Copy link

adcha17 commented Feb 14, 2018

Throws below error in console:
emmeterror
Chrome Version:64.0.3282.140 (Official Build) (64-bit)
Any workaround to resolve this issue?
@greaveselliott
Copy link

@adcha17 it's not worked for a while, not sure if this project is still maintained?

@brndto
Copy link

brndto commented Mar 11, 2018 •
edited
Loading

This should be a fix for LiveStyle using this:
livestyle/re-view#2

Sure something similar would fix it for review but I'm not entirely sure.

As for the question about the project maintenance, there's only one developer so you can't expect stuff to happen quickly, especially since he's working for free & re:view is open source.

jamescodesthings referenced this issue in PacktDev/re-view-chrome Oct 21, 2019
@jamescodesthings
Quick fix for issue #2
c4b8458 
Noticed that findMediaBreakpoints was not working.
Worked through the issue, honestly don't remember exactly which bit fixes things.
Also updated package.json for my own use.
Also extracted findBreakpoints from external project into this one because I just wanted things working.

Could make the same/similar changes to the external project but for the purpose of just making this extension do the thing right, I'm leaving it as is.
@jamescodesthings
Copy link

Updated and working in Chrome 77.x, See the fork, hopefully there's some maintainers around to do the rest. 😄

@jamescodesthings jamescodesthings linked a pull request Oct 21, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue/2 PacktDev/re-view-chrome
4 participants
@greaveselliott @adcha17 @jamescodesthings @brndto