Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

message ids of outgoing to-device messages are not logged #8872

Open
richvdh opened this issue Jul 26, 2024 · 5 comments
Open

message ids of outgoing to-device messages are not logged #8872

richvdh opened this issue Jul 26, 2024 · 5 comments
Assignees
@manuroe

Comments

@richvdh
Copy link
Member

richvdh commented Jul 26, 2024

... making it hard to debug UTD errors.
@richvdh
Copy link
Member Author

richvdh commented Jul 26, 2024

oh, it seems like they are, but only after a successful send.

@richvdh richvdh closed this as completed Jul 26, 2024
@richvdh richvdh reopened this Jul 26, 2024
@richvdh
Copy link
Member Author

richvdh commented Jul 26, 2024 •
edited
Loading

No, this really isn't working right. This line should contain message IDs, but does not:

2024-07-17T19:18:12*471GMT+00:00Z 109840 D/ /Tag:  INFO share_room_key{room_id="!KlgIJeiotNGZkxSqRi:matrix.org" session_id="CRtLj43zaz99+UdokqEgHZxBj/w3lTXqmbK1bswAFMw"}: matrix_sdk_crypto::session_manager::group_sessions: Created batch of to-device messages of type m.room.encrypted request_id="9c14fef9bf8a4b1a9896e5caa1c2494a" message_list=[("@c4rsten:one.ems.host", "YHNOSDFBLM"), ("@cab404:matrix.org", "FSQQNKXFOA"), ("@cab404:matrix.org", "KGWASIENRM"), ("@cab404:matrix.org", "KRFTIXJZGW"), ("@cab404:matrix.org", "ZAXUPNYLNU"), ("@caggegi:matrix.org", "IBRVTHTHYD"), ("@caggegi:matrix.org", "UEOQQWEGOJ")...]

It looks like the bindings are building matrix-sdk-crypto without the message-ids feature.

@richvdh
Copy link
Member Author

richvdh commented Jul 26, 2024

It looks like the bindings are building matrix-sdk-crypto without the message-ids feature.

(I don't even know why that's an option; not enabling it is silly IMHO)

@richvdh richvdh self-assigned this Jul 29, 2024
@richvdh richvdh mentioned this issue Jul 30, 2024
Merged
richvdh added a commit to matrix-org/matrix-rust-sdk that referenced this issue Jul 30, 2024
@richvdh
Make message-ids feature the default (#3776)
40e3a96 
The feature is now a no-op.

Will fix (I hope)
element-hq/element-android#8872
@richvdh
Copy link
Member Author

richvdh commented Jul 30, 2024

This now needs an update to the element-android build to use the latest version of matrix-sdk-crypto. Who can help me with that?

/cc @ganfra @bmarty ?

@richvdh
Copy link
Member Author

richvdh commented Sep 3, 2024

@manuroe says there will be a release of EA around September 17th, which should fix this.

@richvdh richvdh assigned manuroe and unassigned richvdh Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @manuroe