Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation - no check on form creation #314

Open
Tracked by #321
PascalinDe opened this issue Aug 30, 2023 · 2 comments
Open
Tracked by #321

Validation - no check on form creation #314

PascalinDe opened this issue Aug 30, 2023 · 2 comments

Comments

@PascalinDe
Copy link
Contributor

PascalinDe commented Aug 30, 2023

currently, it is possible to create an empty form (no titles, no subjects, ...)

@PascalinDe PascalinDe self-assigned this Aug 30, 2023
@PascalinDe
Copy link
Contributor Author

the problem is that the check checks that MainTitle is set and a string, and the data that gets passed is:

'{"en":"","fr":"","de":""}'

so the check passes, but no actual data is passed

@PascalinDe
Copy link
Contributor Author

#313 fixes broken test on form title - however as far as I can see in the code the subjects should not be empty either and this is still broken, I'll add a separate PR for that

@PascalinDe PascalinDe changed the title no check on form creation Validation - no check on form creation Sep 1, 2023
@PascalinDe PascalinDe removed their assignment Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

No branches or pull requests

1 participant