Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code related to parameter prediction #837

Open
hfp opened this issue Sep 3, 2024 · 1 comment
Open

Remove code related to parameter prediction #837

hfp opened this issue Sep 3, 2024 · 1 comment

Comments

@hfp
Copy link
Member

hfp commented Sep 3, 2024

          My proposal is to remove all code related to prediction incl. the Jupyter notebook(s). This and future pre-commits like the Python linter rejects for instance `src/acc/libsmm_acc/notebooks/inspect_training_data.ipynb`. Without porting this code to new versions of their dependencies, the pre-commit remains red. An alternative is to exclude/green-list related failures. The real concern is the lack of testing for the prediction. Removing the code also fixes the [security warning](https://github.com/cp2k/dbcsr/security/dependabot).

Originally posted by @hfp in #836 (comment)

hfp added a commit to hfp/dbcsr that referenced this issue Sep 3, 2024
hfp added a commit to hfp/dbcsr that referenced this issue Sep 3, 2024
@alazzaro
Copy link
Member

alazzaro commented Sep 3, 2024

crosslink to #805

hfp added a commit to hfp/dbcsr that referenced this issue Sep 4, 2024
hfp added a commit to hfp/dbcsr that referenced this issue Sep 10, 2024
hfp added a commit to hfp/dbcsr that referenced this issue Sep 10, 2024
alazzaro pushed a commit that referenced this issue Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants