Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merkle tree support #27

Open
1 task done
Tracked by #9
mfw78 opened this issue Sep 17, 2023 · 0 comments
Open
1 task done
Tracked by #9

feat: merkle tree support #27

mfw78 opened this issue Sep 17, 2023 · 0 comments
Labels
E:1.3: Merkle Tree Support https://github.com/cowprotocol/pm/issues/9

Comments

@mfw78
Copy link
Contributor

mfw78 commented Sep 17, 2023 •
edited
Loading

Problem

Currently all smart orders that are processed by the watch tower are only single orders. There is presently no testing of merkle proofs.

Suggested solution

Dog food merkle proofs for testing the watch tower to ensure that these are handled the same as single orders.

Alternatives considered

N/A

Additional context

There may be cross-library dependencies on cow-sdk when handling multiple orders.

Acceptance criteria
@mfw78 mfw78 mentioned this issue Sep 17, 2023
Closed
17 tasks
@mfw78 mfw78 changed the title Check auth for merkle proof based smart orders feat: verify merkle proof for authorising smart orders Sep 17, 2023
@mfw78 mfw78 added enhancement New feature or request E:2023-composable-cow labels Sep 17, 2023
@mfw78 mfw78 added E:1.3: Merkle Tree Support https://github.com/cowprotocol/pm/issues/9 and removed E:2023-composable-cow labels Sep 25, 2023
@mfw78 mfw78 mentioned this issue Sep 30, 2023
Open
5 tasks
@mfw78 mfw78 changed the title feat: verify merkle proof for authorising smart orders feat: merkle tree support Sep 30, 2023
@mfw78 mfw78 removed the enhancement New feature or request label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:1.3: Merkle Tree Support https://github.com/cowprotocol/pm/issues/9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfw78