Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dont generate contract types any more, use SDK #19

Open
anxolin opened this issue Aug 30, 2023 · 2 comments
Open

chore: dont generate contract types any more, use SDK #19

anxolin opened this issue Aug 30, 2023 · 2 comments
Labels
blocked This issue is blocked by some other work enhancement New feature or request

Comments

@anxolin
Copy link
Contributor

anxolin commented Aug 30, 2023

We depend on the SDK now, so we can use the SDK types, including:

  • ComposableCoW,
  • ComposableCoWInterface,
  • IConditionalOrder,
  • etc.

This task is for deleting the process of generating the types, and using the SDK imports instead
@anxolin anxolin mentioned this issue Aug 30, 2023
Merged
@mfw78 mfw78 added the infra Infra, devops, CI and related tasks label Sep 18, 2023
@mfw78 mfw78 changed the title Dont generate contract types any more, use SDK chore: dont generate contract types any more, use SDK Sep 18, 2023
@mfw78 mfw78 added E:2023-composable-cow enhancement New feature or request and removed E:2023-composable-cow infra Infra, devops, CI and related tasks labels Sep 18, 2023
@mfw78
Copy link
Contributor

mfw78 commented Sep 29, 2023

From some work that I did looking at this, I think some of the kindToString, balanceToString as well as some generated contract types haven't been exported / upstreamed to the cow-sdk. I'll flag this as blocked before those happen.

@mfw78 mfw78 added the blocked This issue is blocked by some other work label Sep 29, 2023
@anxolin
Copy link
Contributor Author

anxolin commented Oct 3, 2023

Yes, those logics should be in the SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This issue is blocked by some other work enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anxolin @mfw78