Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue raising error when logging in #197

Open
tommygod3 opened this issue Jun 24, 2019 · 7 comments
Open

Issue raising error when logging in #197

tommygod3 opened this issue Jun 24, 2019 · 7 comments

Comments

@tommygod3
Copy link
Contributor

The exception caught by:

return self.login_failure(message=result.error.message)

doesn't always have a .message attribute. Using str(result.error) works will all exceptions.

@tommygod3
Copy link
Contributor Author

Error goes from:
1
where the true error is obscured, to:
2
where the true error can be seen.

@tommygod3
Copy link
Contributor Author

tommygod3 commented Jun 24, 2019

The error that can be seen in the second image seems to be a problem with the authomatic library by the way, not with Phoenix. authomatic/authomatic#199

@cehbrecht
Copy link
Member

Since authomatic is not so well maintained we might skip it and move to oauthlib only, maybe together with pyramid-oauthlib. We would have logins for CEDA/ESGF, github, google, ...

@tommygod3
Copy link
Contributor Author

Sounds like a good solution to me.

@cehbrecht
Copy link
Member

would you like to give it a try?

@tommygod3
Copy link
Contributor Author

Yeah I can give it a try, removing authomatic and consequently OpenID, and instead using oauthlib sounds good. I will develop these changes in cedadev/pyramid-phoenix so I can collaborate with @watucker

@tommygod3
Copy link
Contributor Author

@cehbrecht Unfortunately my last day on placement is tomorrow and I never had the time to look at doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants