{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":142940518,"defaultBranch":"main","name":"aws-c-http","ownerLogin":"awslabs","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-07-31T00:07:24.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3299148?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726454032.0","currentOid":""},"activityList":{"items":[{"before":"f6ae550764094a92f328ea0b137f89223a3ce579","after":null,"ref":"refs/heads/increase-timeout","pushedAt":"2024-09-16T02:33:33.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"}},{"before":"4b1634be75f1a0f63d494ae91a437729750ce269","after":"6068653e1d582bd8e7d1c9f81f86beaf10444e3d","ref":"refs/heads/main","pushedAt":"2024-09-16T02:33:31.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"increase timeout for http integration tests (#487)","shortMessageHtmlLink":"increase timeout for http integration tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2525715562\" data-permission-text=\"Title is private\" data-url=\"https://github.com/awslabs/aws-c-http/issues/487\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/awslabs/aws-c-http/pull/487/hovercard\" href=\"https://github.com/awslabs/aws-c-http/pull/487\">#487</a>)"}},{"before":null,"after":"f6ae550764094a92f328ea0b137f89223a3ce579","ref":"refs/heads/increase-timeout","pushedAt":"2024-09-13T21:16:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"increase timeout for http tests","shortMessageHtmlLink":"increase timeout for http tests"}},{"before":"b7c62cabff7d36f01647e7f9816da904bc8d260c","after":null,"ref":"refs/heads/fix-pending-acquisition-timeout","pushedAt":"2024-09-10T19:58:44.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"}},{"before":"4e74ab1e3702763e0b87bd1752f5a37c2f0400ac","after":"4b1634be75f1a0f63d494ae91a437729750ce269","ref":"refs/heads/main","pushedAt":"2024-09-10T19:58:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"},"commit":{"message":"Fix max_pending_connection_acquisitions to respect connection pool size (#485)","shortMessageHtmlLink":"Fix max_pending_connection_acquisitions to respect connection pool si…"}},{"before":"f38f50aa6ccce6d31c20e1d2d3fc90ef011e7674","after":"b7c62cabff7d36f01647e7f9816da904bc8d260c","ref":"refs/heads/fix-pending-acquisition-timeout","pushedAt":"2024-09-05T20:19:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"},"commit":{"message":"update doc","shortMessageHtmlLink":"update doc"}},{"before":"d01d7eb324c65a3aa3f18b90397eb01e8d8fe418","after":"f38f50aa6ccce6d31c20e1d2d3fc90ef011e7674","ref":"refs/heads/fix-pending-acquisition-timeout","pushedAt":"2024-09-05T18:13:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"},"commit":{"message":"lint","shortMessageHtmlLink":"lint"}},{"before":"bd66387318dda7e7058eee01bf34833fcebf2425","after":"d01d7eb324c65a3aa3f18b90397eb01e8d8fe418","ref":"refs/heads/fix-pending-acquisition-timeout","pushedAt":"2024-09-05T18:12:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"},"commit":{"message":"fix another case","shortMessageHtmlLink":"fix another case"}},{"before":"8d171e9cab524e2e699b92844e0e3031a5003ab8","after":"bd66387318dda7e7058eee01bf34833fcebf2425","ref":"refs/heads/fix-pending-acquisition-timeout","pushedAt":"2024-09-05T17:46:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"},"commit":{"message":"update builder","shortMessageHtmlLink":"update builder"}},{"before":null,"after":"8d171e9cab524e2e699b92844e0e3031a5003ab8","ref":"refs/heads/fix-pending-acquisition-timeout","pushedAt":"2024-09-05T17:41:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"},"commit":{"message":"update pending acquisitions timeout","shortMessageHtmlLink":"update pending acquisitions timeout"}},{"before":"66b9fced53f0032705f70e88e8f05581183559af","after":"3225effefb4d6ae99e7f5edd51a55df6fc5d83fa","ref":"refs/heads/update-cmake","pushedAt":"2024-08-19T22:28:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"graebm","name":"Michael Graeb","path":"/graebm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24399397?s=80&v=4"},"commit":{"message":"Merge branch 'main' into update-cmake","shortMessageHtmlLink":"Merge branch 'main' into update-cmake"}},{"before":null,"after":"66b9fced53f0032705f70e88e8f05581183559af","ref":"refs/heads/update-cmake","pushedAt":"2024-08-19T20:18:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"graebm","name":"Michael Graeb","path":"/graebm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24399397?s=80&v=4"},"commit":{"message":"Update required CMake","shortMessageHtmlLink":"Update required CMake"}},{"before":"791c582bc60da0bd5139bf353fe2ce10da07ed6b","after":null,"ref":"refs/heads/fix-websocket","pushedAt":"2024-08-16T16:26:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"graebm","name":"Michael Graeb","path":"/graebm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24399397?s=80&v=4"}},{"before":"7db2452238caece2d3a91e6cbed75324edccea7d","after":"4e74ab1e3702763e0b87bd1752f5a37c2f0400ac","ref":"refs/heads/main","pushedAt":"2024-08-16T16:26:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"graebm","name":"Michael Graeb","path":"/graebm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24399397?s=80&v=4"},"commit":{"message":"Fix websocket shutdown behavior (#483)\n\nThe bug was introduced in [PR #474](https://github.com/awslabs/aws-c-http/pull/474/files#diff-ee776c7576cfff50a64158d59a6173ab9a0aa373150574aa9987b4f8726b58e3)\r\n  - `is_writing_stopped = true` shouldn't be set directly, there's a helper function `s_stop_writing()` that ensures subsequent calls to `aws_websocket_send_frame()` will fail.\r\n\r\nLet's take a whole new approach these channel-shutdown-window-deadlock issues:\r\n- add `s_stop_reading_and_dont_block_shutdown()` function that sets `is_reading_stopped = true`, but also increments the read window so that channel shutdown won't deadlock.\r\n    - Most places that were setting `is_reading_stopped = true` now use this helper instead\r\n- Revamp how `aws_channel_shutdown()` is called. Lots of channel behavior has changed since [this websocket code was written](https://github.com/awslabs/aws-c-http/pull/48).\r\n  - If on the channel-thread, just call `aws_channel_shutdown()`\r\n      - now that [aws_channel_shutdown()](https://github.com/awslabs/aws-c-io/pull/172) is always async, we don't need to defensively schedule a task to call it\r\n  - If off-thread, use `s_schedule_channel_shutdown_from_offthead()`\r\n      - now that this is only called from `aws_websocket_close()`, or when the refcount goes to zero, we can assume the user is OK if reading stops, and it can call `s_stop_reading_and_dont_block_shutdown()` on the way to shutting down.\r\n- Add the test to verify that send after close should fail\r\n\r\nCo-authored-by: Michael Graeb <graebm@amazon.com>","shortMessageHtmlLink":"Fix websocket shutdown behavior (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2468545112\" data-permission-text=\"Title is private\" data-url=\"https://github.com/awslabs/aws-c-http/issues/483\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/awslabs/aws-c-http/pull/483/hovercard\" href=\"https://github.com/awslabs/aws-c-http/pull/483\">#483</a>)"}},{"before":"c20d12162452e06d2a21662189c47117eeb60d13","after":"791c582bc60da0bd5139bf353fe2ce10da07ed6b","ref":"refs/heads/fix-websocket","pushedAt":"2024-08-16T00:48:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"graebm","name":"Michael Graeb","path":"/graebm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24399397?s=80&v=4"},"commit":{"message":"Use different shutdown paths for internal stuff on the channel thread, vs calls from off-thread caused directly by the user","shortMessageHtmlLink":"Use different shutdown paths for internal stuff on the channel thread…"}},{"before":null,"after":"c20d12162452e06d2a21662189c47117eeb60d13","ref":"refs/heads/fix-websocket","pushedAt":"2024-08-15T17:18:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"make sure send after close fails","shortMessageHtmlLink":"make sure send after close fails"}},{"before":null,"after":"558a323653b37e13f63db8cbf670c5aa0028f6f7","ref":"refs/heads/visibility-hidden","pushedAt":"2024-08-14T19:00:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"graebm","name":"Michael Graeb","path":"/graebm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24399397?s=80&v=4"},"commit":{"message":"Default symbol visibility to hidden in static libs too","shortMessageHtmlLink":"Default symbol visibility to hidden in static libs too"}},{"before":"c9cfa04f2eb8449d3aa1c6e6f4881bf79e3af66a","after":null,"ref":"refs/heads/connection-shutdown","pushedAt":"2024-08-07T22:29:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"}},{"before":"b5684c77f6247f182a0376f1371f250ffe8624a5","after":"7db2452238caece2d3a91e6cbed75324edccea7d","ref":"refs/heads/main","pushedAt":"2024-08-07T22:29:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"Connection shutdown with buffered data (#482)","shortMessageHtmlLink":"Connection shutdown with buffered data (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2449605137\" data-permission-text=\"Title is private\" data-url=\"https://github.com/awslabs/aws-c-http/issues/482\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/awslabs/aws-c-http/pull/482/hovercard\" href=\"https://github.com/awslabs/aws-c-http/pull/482\">#482</a>)"}},{"before":"28246c9f55de39616ad89119375dabc85a77ab64","after":"c9cfa04f2eb8449d3aa1c6e6f4881bf79e3af66a","ref":"refs/heads/connection-shutdown","pushedAt":"2024-08-07T00:27:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"fix the bug and use a state instead of two bool","shortMessageHtmlLink":"fix the bug and use a state instead of two bool"}},{"before":"6eb3dc79d36f85485510ac980842c239b6560eb1","after":"28246c9f55de39616ad89119375dabc85a77ab64","ref":"refs/heads/connection-shutdown","pushedAt":"2024-08-06T00:04:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"add couple more tests and fix the shutdown","shortMessageHtmlLink":"add couple more tests and fix the shutdown"}},{"before":null,"after":"1f87e9917957f6885fa6da098c4e3ecb5e731a34","ref":"refs/heads/shutdown-test","pushedAt":"2024-08-05T22:53:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"add the test only","shortMessageHtmlLink":"add the test only"}},{"before":"e6119b0dec10dd42634a51f377a2e925a3ea2cc1","after":"6eb3dc79d36f85485510ac980842c239b6560eb1","ref":"refs/heads/connection-shutdown","pushedAt":"2024-08-05T22:52:15.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"Merge branch 'main' into connection-shutdown","shortMessageHtmlLink":"Merge branch 'main' into connection-shutdown"}},{"before":"89a3c2a9b44125b7241d65ed9f6107ea7b71e825","after":null,"ref":"refs/heads/max-pending-acquisitions","pushedAt":"2024-08-05T22:51:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"}},{"before":"13f427b2ccab61849272e9eda4c801ccfc50644a","after":"b5684c77f6247f182a0376f1371f250ffe8624a5","ref":"refs/heads/main","pushedAt":"2024-08-05T22:51:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"},"commit":{"message":"Support MaxPendingConnectionAcquisitions (#481)","shortMessageHtmlLink":"Support MaxPendingConnectionAcquisitions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2449187131\" data-permission-text=\"Title is private\" data-url=\"https://github.com/awslabs/aws-c-http/issues/481\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/awslabs/aws-c-http/pull/481/hovercard\" href=\"https://github.com/awslabs/aws-c-http/pull/481\">#481</a>)"}},{"before":"6a64e34e8142c6a33d71230136c9ed2c032751c6","after":"e6119b0dec10dd42634a51f377a2e925a3ea2cc1","ref":"refs/heads/connection-shutdown","pushedAt":"2024-08-05T22:48:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"add comments","shortMessageHtmlLink":"add comments"}},{"before":"3be50b7219308505bdf5799760d042959026eb29","after":"6a64e34e8142c6a33d71230136c9ed2c032751c6","ref":"refs/heads/connection-shutdown","pushedAt":"2024-08-05T22:45:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"add test","shortMessageHtmlLink":"add test"}},{"before":null,"after":"3be50b7219308505bdf5799760d042959026eb29","ref":"refs/heads/connection-shutdown","pushedAt":"2024-08-05T22:38:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"TingDaoK","name":"Dengke Tang","path":"/TingDaoK","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26829806?s=80&v=4"},"commit":{"message":"potential fix","shortMessageHtmlLink":"potential fix"}},{"before":"2111b0aea3b36e37ae5e6b166aab467e06ae1bfb","after":"89a3c2a9b44125b7241d65ed9f6107ea7b71e825","ref":"refs/heads/max-pending-acquisitions","pushedAt":"2024-08-05T20:55:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"},"commit":{"message":"lint","shortMessageHtmlLink":"lint"}},{"before":"09314a9a70a6dd34f4f8389bdee734196b088669","after":"2111b0aea3b36e37ae5e6b166aab467e06ae1bfb","ref":"refs/heads/max-pending-acquisitions","pushedAt":"2024-08-05T20:51:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"waahm7","name":"Waqar Ahmed Khan","path":"/waahm7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7613045?s=80&v=4"},"commit":{"message":"docs","shortMessageHtmlLink":"docs"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNlQwMjozMzozMy4wMDAwMDBazwAAAAS2-8TD","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNlQwMjozMzozMy4wMDAwMDBazwAAAAS2-8TD","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0wNVQyMDo1MToyNC4wMDAwMDBazwAAAASSb4yX"}},"title":"Activity · awslabs/aws-c-http"}