Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to FAQ: I installed the latest version but amber version does not display it. #50

Open
hhzl opened this issue Jan 17, 2015 · 7 comments
Labels

Comments

@hhzl
Copy link
Member

hhzl commented Jan 17, 2015

From: amber #1131

Answer
There is amber-cli and amber for the client in the bower_components folder. They do not need to be in the same version.

On the command line

   amber version

gives you the version of the amber-cli package. Check bower_components/amber/bower.json and bower_components/amber/package.json for the client side version.

The version of Amber used in the amber init command is hard coded in https://github.com/amber-smalltalk/grunt-init-amber/blob/master/template.js

@hhzl hhzl added the question label Jan 17, 2015
@ghost
Copy link

ghost commented Jan 17, 2015

More details: version of cli is loosely coupled to version produced in amber init (and for things to work, amber cli should be similarly loosely coupled with version of amber used in the projects, otherwise things may not work correctly). This loose coupling, is that most significant number is the same. That is, while in 0.x.y state, amber cli version, version generated in amber init, and version used in the project should all be 0.x.y with same x but possibly different y; in the future in x.y.z state, again only x should be same, y and z can be different (also call "mutually compatible" in semver, denoted by ^a.b.c notation).

@mkroehnert
Copy link

@Herby I propose removing the current amber version command since it is not clear which version is actually meant (as I already mentioned on Gitter).
It could be any version of

  • amber-cli
  • amber used to build amber-cli (current meaning)
  • amber used in the current project
  • amber used for generating a new project with amber init

@ghost
Copy link

ghost commented Jan 17, 2015

amber-cli does not have a version per se, so only the rest of the three can be candidates. It may be possible to make it "amber used in the current project" if really wanted (llok for config.js, load it, use it to find require.js, load it, use the config, load amber, evaulate Smalltalk version, show the result). Just, the question is if it is worth it.

@ghost
Copy link

ghost commented Jan 17, 2015

(ah, yes, it has, the one in package.json... hm, ok)

@mkroehnert
Copy link

the current implementation is evaluating Smalltalk version and showing the result.
But this evaluates to the version amber-cli was compiled with.

@ghost
Copy link

ghost commented Jan 17, 2015

As for "Check bower_components/amber/bower.json and bower_components/amber/package.json", the safest bet is to check bower_components/amber/.bower.json (with dot), as it contains what bower actually resolved while installing it.

@ghost
Copy link

ghost commented Jan 17, 2015

Sure, I was talking of loading the local amber and evaulating after it's loaded.

Manfred Kröhnert wrote:

the current implementation is evaluating |Smalltalk version| and
showing the result.
But this evaluates to the version |amber-cli| was compiled with.


Reply to this email directly or view it on GitHub
#50 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants