Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When parsing Event Bytes of Old (2.0.1) Slippi files crashes program #103

Open
efthymew opened this issue Aug 15, 2024 · 1 comment
Open

Comments

@efthymew
Copy link

libmelee (including all the way back to version 0.10.1 crashes when reading a 2.0.1 slippi file because it enforces EventType when reading, and in these files you will eventually read the bytes 0x3d from the event bytes, which is not a valid EventType, leading to the crash. is 0x3d not the correct event byte code for gecko codes? See: https://github.com/project-slippi/slippi-wiki/blob/master/SPEC.md#events

@efthymew
Copy link
Author

temporary fix is adding 0x3d to the event bytes enum. it appears that the gamestate is valid through the entirety of the calls to .step() after changing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant