Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parsing of project_paraent_name #1

Open
ERT-Kim opened this issue May 14, 2020 · 5 comments
Open

Wrong parsing of project_paraent_name #1

ERT-Kim opened this issue May 14, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ERT-Kim
Copy link

ERT-Kim commented May 14, 2020

For getting project_parent_name, following two lines of code are used.

project_parent_name = project_name[:-len('-dists')]
project_parent_name = project_parent_name[:project_parent_name.rindex('-')]

I think the second line is redundant code causing error. (ValueError: substring not found)
Distribution files are compiled under 'GameName-dist' folder as 'GameName-market', so I think it will work well with the first line (and it really is, as I have tried)

@Happiness-plus Happiness-plus added the bug Something isn't working label May 14, 2020
@Happiness-plus
Copy link

@ERT-Kim would you like to fix it? I am hiring developers right now.
I have to disclose it’s unpaid work. However, you don’t have to clock in more than 10 hours a week and the studio I help run is pretty chill.

@ERT-Kim
Copy link
Author

ERT-Kim commented May 14, 2020

It will be just a few lines of fix which anyone can do, I think. Forking this project, make commits, and sending pull request are too tiresome.

@Happiness-plus
Copy link

I wasn’t expecting you to do all of that lol
For something this easy, I wouldn’t mind you committing to master and calling it a day,
@ERT-Kim I do need help with bigger tasks though if you’re interested in joining us.
I am planning on making a job posting by the end of the week anyway.

@ERT-Kim
Copy link
Author

ERT-Kim commented May 14, 2020

Well... it will be better if your teammates (who you have assigned this issue to) double check my suggestions, I think.
Also thanks for your offer, but I already have my own VN team and project working on. I think you can have some other better programmers than me. (If some of my comments seems to be rude, it is just because I'm not familiar with English. Sorry!)

@Happiness-plus
Copy link

@ERT-Kim alright cool.
See ya.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants