-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong parsing of project_paraent_name #1
Comments
@ERT-Kim would you like to fix it? I am hiring developers right now. |
It will be just a few lines of fix which anyone can do, I think. Forking this project, make commits, and sending pull request are too tiresome. |
I wasn’t expecting you to do all of that lol |
Well... it will be better if your teammates (who you have assigned this issue to) double check my suggestions, I think. |
@ERT-Kim alright cool. |
For getting project_parent_name, following two lines of code are used.
project_parent_name = project_name[:-len('-dists')]
project_parent_name = project_parent_name[:project_parent_name.rindex('-')]
I think the second line is redundant code causing error. (ValueError: substring not found)
Distribution files are compiled under 'GameName-dist' folder as 'GameName-market', so I think it will work well with the first line (and it really is, as I have tried)
The text was updated successfully, but these errors were encountered: