Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TADA_DepthProfilePlot future improvements - list of plots and make more concise #499

Open
hillarymarler opened this issue Jul 15, 2024 · 4 comments
Assignees
Labels
Future Improvement Minimum viable function complete, issue includes potential future improvements More Research Needed Tables&Figures TADA Team Discussion Usability

Comments

@hillarymarler
Copy link
Collaborator

Other visualization functions including TADA_Histogram, TADA_Boxplot, and TADA_Scatterplot can create a list of plots if the input is an unfiltered data frame. Should this functionality be included in TADA_DepthProfilePlot?

Would it be useful for a plot to be created for all Monitoring Locations in the input data frame that contained results for one (or more) of the user-specified TADA.ComparableDataIdentifiers?

@hillarymarler hillarymarler added Future Improvement Minimum viable function complete, issue includes potential future improvements Tables&Figures Usability TADA Team Discussion More Research Needed labels Jul 15, 2024
@hillarymarler hillarymarler changed the title TADA_DepthProfilePlot cannot generate list of plots TADA_DepthProfilePlot future improvements - list of plots and make more concise Jul 22, 2024
@hillarymarler
Copy link
Collaborator Author

An additional improvement that could be considered for this function is to write an internal function that would handle the plotting of depth unit characteristics vs. other characteristics. This would make the code much more concise and easier to edit in the future.

@hillarymarler
Copy link
Collaborator Author

@wokenny13 - tagging you in case the looping approach you would like to investigate for the grouped scatterplot may be useful here too.

@wokenny13 wokenny13 self-assigned this Aug 15, 2024
@wokenny13
Copy link
Collaborator

Thoughts on horizontal lines to indicated depth category profile (Surface, Middle, Bottom)?

image

Thoughts on a side by side plot for when the two characteristics may have unit values that differ, like with the example in the R document of Data_6Tribes_5y_Harmonized of DO and Conductivity? I pulled this random example I found of what I have envisoned.

image

@wokenny13
Copy link
Collaborator

Both can be good, but perhaps give user the ability for a single plot or split plot argument - should consider how this will be handled in R Shiny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Future Improvement Minimum viable function complete, issue includes potential future improvements More Research Needed Tables&Figures TADA Team Discussion Usability
Projects
None yet
Development

No branches or pull requests

2 participants