From a2ffbdf17beb43f92ad7c61dbf91aba44a10cee4 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Mon, 16 Jul 2018 19:25:54 +0200 Subject: [PATCH 1/2] Composer: Stabilize minimum PHPCompatibility version The Joomla ruleset references the following sniffs: * PHPCompatibility.PHP.NewClasses - been in the repo from before the first tag * PHPCompatibility.PHP.NewConstants - introduced in 8.1.0 * PHPCompatibility.PHP.NewFunctions - been in the repo from before the first tag * PHPCompatibility.PHP.NewInterfaces`- introduced in 7.0.3 In other words, the minimum version of PHPCompatibility should be 8.1.0 for this release. This will also prevent an update to PHPCompatibility 9.0.0 before we've had a chance to update the ruleset to reflect the new sniff names. --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 1d09fba..2546c0a 100644 --- a/composer.json +++ b/composer.json @@ -22,7 +22,7 @@ "source" : "https://github.com/PHPCompatibility/PHPCompatibilityJoomla" }, "require" : { - "phpcompatibility/php-compatibility" : "*" + "phpcompatibility/php-compatibility" : "^8.1" }, "suggest" : { "dealerdirect/phpcodesniffer-composer-installer": "^0.4.3 || This Composer plugin will sort out the PHPCS 'installed_paths' automatically.", From cb9e4496cbc2464e02004a95276f8f8d1bdc40dc Mon Sep 17 00:00:00 2001 From: jrfnl Date: Mon, 16 Jul 2018 19:39:07 +0200 Subject: [PATCH 2/2] Travis: do not validate the composer.json of dependencies This should be done in their own Travis script. --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index e6ee417..cb13b79 100644 --- a/.travis.yml +++ b/.travis.yml @@ -44,4 +44,4 @@ script: # Validate the composer.json file. # @link https://getcomposer.org/doc/03-cli.md#validate - - composer validate --no-check-all --with-dependencies --strict + - composer validate --no-check-all --strict