Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate string read with generalized container read #296

Open
DanRStevens opened this issue Apr 21, 2019 · 0 comments
Open

Consolidate string read with generalized container read #296

DanRStevens opened this issue Apr 21, 2019 · 0 comments
Labels
C++17 Update requires C++17 features

Comments

@DanRStevens
Copy link
Member

As mentioned in PR #288, the string read method can be consolidated with the generalized container read method. However, this needs C++17 support to enable, as the string.data() method doesn't have a non-const overload until C++17.

Consolidating the two methods will allow the read code to match the consolidation in the corresponding write code.
@DanRStevens DanRStevens added the C++17 Update requires C++17 features label Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++17 Update requires C++17 features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanRStevens