Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching functionality... #50

Open
ArjixWasTaken opened this issue Feb 15, 2021 · 1 comment
Open

Searching functionality... #50

ArjixWasTaken opened this issue Feb 15, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ArjixWasTaken
Copy link

Welp, just like in anime-dl/anime-downloader, I want to get your opinion on searching functionalities...

As a feature it would need a lot of rework in the core of the repo.
But I believe it's worth the effort.

Once I get familiar with the inner workings of monkey-dl, I'll try to add it myself, but adding a feature whilst not knowing if it will actually get merged does not sound nice.
(Yes, I know that you have to look at my PR to decide if you want it to be merged or not, I'm just asking if you would like this in general.)

@Oshan96
Copy link
Owner

Oshan96 commented Feb 15, 2021

Hi @ArjixGamer, I do like the idea of the searching functionality, and I'll gladly accept any pull request with such functionality. However, since I have completely reworked the packages and some of the files in dev branch, it would be best to be working and sending a PR to the dev branch (otherwise we both will have issues, just like the other PR on hold because it gives me collisions and I don't have too much time to completely go through and fix old packages and files too)

Any help is appreciated, and as I have mentioned, the main reason for the PR was not merged yet was because of the issues I have mentioned above.

@Oshan96 Oshan96 added the enhancement New feature or request label Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants