Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying SG parameters #636

Open
jsuarezs opened this issue Aug 27, 2021 · 4 comments
Open

Modifying SG parameters #636

jsuarezs opened this issue Aug 27, 2021 · 4 comments

Comments

@jsuarezs
Copy link
Contributor

jsuarezs commented Aug 27, 2021

Hello team.

I'm requesting these changes as our customers are getting confusing.

For the StorageClasses: We're not using anymore the provisioner "netapp.io/trident" and needs to be replaced by "csi.trident.netapp.io" in all of them.
For the CVS backend configuration doesn't make sense to have the parameter "limitVolumeSize": "50Gi" since the minimum volume size is 100Gi so using that they will get the error that the size requested is bigger than the one set here.

Pull request: #620.

I really appreciate you take care of this. Thanks a lot !

@balaramesh
Copy link
Contributor

@jsuarezs thank you for bringing this to our attention. Can you sign the CCLA agreement so we can accept your PR? Thanks!

@jsuarezs
Copy link
Contributor Author

jsuarezs commented Aug 31, 2021 via email

@balaramesh
Copy link
Contributor

@jsuarezs I noticed that your PR was targeting stable/v21.04. I wanted to offer some context as to why the examples/docs still point to netapp.io/trident in the docs for 21.04 and releases prior. v21.04 supports Kubernetes versions 1.11 and onwards. For Kubernetes versions <1.14, Trident can be configured to run as a traditional, non-CSI storage provisioned (where the provisioner is set to netapp.io/trident). It can also be installed on Kubernetes versions 1.14 and above, where it will run as a CSI provisioner (which needs provisioner to be set to either netapp.io/trident or csi.trident.netapp.io). The important thing to note here is that Trident will also automatically handle storageClasses with netapp.io/trident, and update them to use csi.trident.netapp.io.

I agree that limitVolumeSize can be removed from the examples

@jsuarezs
Copy link
Contributor Author

jsuarezs commented Sep 2, 2021

Hello Bala.

Thanks a lot for the explanation that's really useful and I think we could include it the docs but anyway I agree on that.
Regarding the limitVolumeSize parameter is something we could remove (I did another commit just in case).

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants