Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deployment triggering from CI job #90

Closed
tegefaulkes opened this issue Dec 22, 2023 · 3 comments · Fixed by #94
Closed

Remove deployment triggering from CI job #90

tegefaulkes opened this issue Dec 22, 2023 · 3 comments · Fixed by #94
Assignees
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity

Comments

@tegefaulkes
Copy link
Contributor

tegefaulkes commented Dec 22, 2023

Specification

I need to remove the part of the job integration:deployment that triggers the testnet seed nodes tasks restarting with the newly deployed image. But it depends on the new lambda handling that for us. Right now I don't think it's triggering properly so I'm leaving the CI job as is to be updated later.

Additional context

Tasks

  1. Verify the lambda is triggering the deployment properly.
  2. Remove the part of the CI job integration:deployment that triggers the tasks restarting.
  3. The wait-for-deployment.js needs to be parameterised to work with the testnet and mainnet.
  4. The integration tests need to be parameterised to work with the testnet and mainnet.
  5. The wait-for-deployment.js script needs to take into account the CLI version on top of the library version.
  6. we need to add a wait-for-deployment ci job for the mainnet stage.
  7. We need add integration tests ci job for the mainnet stage.
@tegefaulkes tegefaulkes added the development Standard development label Dec 22, 2023
@tegefaulkes tegefaulkes self-assigned this Dec 22, 2023
@tegefaulkes
Copy link
Contributor Author

I need to confirm the status of the lambda triggering the update of the seed nodes from @amydevs.

I believe that @amydevs is also working on including the CLI version in the status information. With that included I'll need to update the wait-for-deploy.js script to use it.

@CMCDragonkai
Copy link
Member

I believe that should be done already. Can you check?

@tegefaulkes
Copy link
Contributor Author

There are actually a few parts needed to complete this so I'm going to be expanding this issue.

  1. Remove the ECS service update from the CI job. This was the main point of this issue and is unchanged.
  2. The wait-for-deployment.js needs to be parameterised to work with the testnet and mainnet.
  3. The integration tests need to be parameterised to work with the testnet and mainnet.
  4. The wait-for-deployment.js script needs to take into account the CLI version on top of the library version.
  5. we need to add a wait-for-deployment ci job for the mainnet stage.
  6. We need add integration tests ci job for the mainnet stage.

This was referenced Jan 15, 2024
@CMCDragonkai CMCDragonkai added the r&d:polykey:supporting activity Supporting core activity label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity
Development

Successfully merging a pull request may close this issue.

2 participants