Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running times are wrong #14

Open
f-f opened this issue Jan 23, 2018 · 1 comment
Open

Running times are wrong #14

f-f opened this issue Jan 23, 2018 · 1 comment

Comments

@f-f
Copy link
Member

f-f commented Jan 23, 2018

Running times for stages are usually displayed as 23:56:44, which are obviously wrong.

@f-f
Copy link
Member Author

f-f commented Jul 3, 2018

Some context about this: we had a bug about times being weird, which was "fixed" by 9792824 ("reverted" in 3093d95).
A posteriori we realized that the running times were weird because some finished was on a different day but at a previous time than the started, so since the running time are capped to 24h in the visualization, we get weird times. So everything is fine if the difference between started and finished attributes of the Pipeline is less than 24h.

We could fix this in several ways:

  1. Display something different if the difference is more than 24h, e.g. branching here
  2. (my favorite) Instead of just diffing the started and finished (which don't actually represent the running time), we should sum all the jobs running times (with the assumption that the sum of the duration of jobs would practically never go over 24h)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant