Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong vendor price on old items created or obtained after Shadowlands / Dragonflight arrived #250

Open
R-Adrian opened this issue May 10, 2024 · 3 comments

Comments

@R-Adrian
Copy link

R-Adrian commented May 10, 2024

Which software were you running?

  • Addon version name: Scrap (Junk Seller) 10.2.11
  • Client used: [Retail 10.2.7]

Have you read the changelog?
yes, read

Please describe the bug.
Old craftable items can be made with Dragonflight / Shadowlands optional reagents and these will sell to vendor for much more than the old version of the same items BUT this addon will report the OLD vendor price when selling to vendor

e.g.
https://www.wowhead.com/item=6238/brown-linen-robe
old item level 5 makes 19 copper when sold to vendor
new item level 163 makes 20g 68s 56c when sold to vendor BUT Scrap (Junk Seller) addon reports only 19 copper gained when selling the item to vendor

Please describe how to reproduce it.

  • craft old recipes but make them with optional reagents
  • set the item as junk (drag it to the sell junk button at vendor)
  • press the sell junk button
  • check in chat the reported vendor price / money gained when selling the new 'junk' item

Optional:

  • check Auction House for crazy below-vendor prices on items with high item levels
  • buy them out, sell to vendor, profit.

Any Screenshots?
If applicable, please add screenshots to help explain your problem.

image

Error Logs are Important!
no LUA error - just vendor price error

@R-Adrian
Copy link
Author

R-Adrian commented May 10, 2024

example 2:
https://www.wowhead.com/item=2578/barbaric-linen-vest
base item level 7 = 22 copper when sold to vendor
item level 163 made with optional reagents = 19g 31s55c

Scrap addon reports only 22c gained from vendoring it but the actual gains are much more.

(tooltip misses a few pieces (item id, base item level) when compared to the item in the first screenshot because i kept enabling / disabling addons to see if it makes any difference - found out it makes no difference to the end result reported by Scrap seller)

image

@R-Adrian
Copy link
Author

R-Adrian commented May 10, 2024

example 3:
https://www.wowhead.com/item=10047/simple-kilt
base item level 7 sells for 24 copper
item level 163 made with optional reagents = 19g 71s 80c

image

Found a lot of these items in the Auction House....
That final line shows how much of a difference is between what Scrap is reporting and what the actual total is after closing the vendor window - sold about 4 sets of these items (12 pieces each set, last one was not a full set)

image

@R-Adrian R-Adrian changed the title wrong vendor price on (old recipes) craftable items made with new Dragonflight optional reagents wrong vendor price on (old recipes) craftable items made with new optional reagents May 10, 2024
@R-Adrian
Copy link
Author

update: i see that this problem happens with a lot of old non-craftable items as well, items with new, higher item levels and stats than the base item and that are dropped after Shadowlands / Dragonflight arrived.
(i'll edit the issue title too)

https://www.wowhead.com/item=159605/ironcrest-baton
base item level 58 = 40s 33c
item level 170 = 42g 1s 7c

image

image

@R-Adrian R-Adrian changed the title wrong vendor price on (old recipes) craftable items made with new optional reagents wrong vendor price on items created or obtained after Shadowlands / Dragonflight arrived May 12, 2024
@R-Adrian R-Adrian changed the title wrong vendor price on items created or obtained after Shadowlands / Dragonflight arrived wrong vendor price on old items created or obtained after Shadowlands / Dragonflight arrived May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant