Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing/Blocking txt in EMWIN reception #3

Closed
ZL1LAC opened this issue Jul 28, 2023 · 1 comment
Closed

Removing/Blocking txt in EMWIN reception #3

ZL1LAC opened this issue Jul 28, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ZL1LAC
Copy link

ZL1LAC commented Jul 28, 2023

Any change you can add this function to the Windows version?

config for reference

[[handler]]
type = "text"
origin = "other"
directory = "./text"
filename = "{time:%Y%m%dT%H%M%SZ}_{filename}"
json = false
exclude_txt = true
@JVital2013
Copy link
Owner

Thanks for the request!

I pulled @tmbates12's original PR for this from pietern#79 and merged it into the Windows port. It's available as of version 1.0.5, which I just released.

This is a great example of the type of issue I will consider addressing, and I will reference back to this request in the future. Typically, I will not address issues that are not windows-specific. I want to minimize deviation from Goestools for Linux to avoid letting this project evolve into something it isn't.

However, this request falls squarely into my general requirements for non-windows specific fixes:

  • There is a PR for this functionality on the original goestools project that has not been rejected
  • The patch is vetted to be stable
  • The patch is either "generally accepted" by a lot of people, or is a new patch necessary to fix issues with the current HRIT transmission

Thanks again!

@JVital2013 JVital2013 self-assigned this Jul 30, 2023
@JVital2013 JVital2013 added the enhancement New feature or request label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants