Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devices actions kebab menu in application view do nothing #4246

Closed
Tracked by #4250
Steve-Mcl opened this issue Jul 24, 2024 · 3 comments · Fixed by #4253
Closed
Tracked by #4250

Devices actions kebab menu in application view do nothing #4246

Steve-Mcl opened this issue Jul 24, 2024 · 3 comments · Fixed by #4253
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working needs-triage Needs looking at to decide what to do size:S - 2 Sizing estimation point

Comments

@Steve-Mcl
Copy link
Contributor

Current Behavior

clicking any of the actions on the kebab of a device does not do anything

chrome_AiTnkLgJIj

Expected Behavior

Should perform the action described

Steps To Reproduce

open application view, select the kebab menu for a device

Environment

  • FlowFuse version: 2.6.x (Prod)
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser: chrome

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@Steve-Mcl Steve-Mcl added bug Something isn't working needs-triage Needs looking at to decide what to do area:frontend For any issues that require work in the frontend/UI size:S - 2 Sizing estimation point labels Jul 24, 2024
@Steve-Mcl
Copy link
Contributor Author

Steve-Mcl commented Jul 24, 2024

I fixed this locally - found the compact view passes devices to the mixin as an array but there were some left over this.devices.set and this.devices.delete map method calls causing exceptions (that are helpfully swallowed by vue)

So I fixed up the 3 places where this.devices were still calling map methods to use array methods. that fixed it up nicely - however - the Applications->Device vue is now broken.

Seems the I am still getting a map object from other views

@joepavitt
Copy link
Contributor

Just confirming, this is not fixed by #4252 - this is a different problem

@Steve-Mcl
Copy link
Contributor Author

Just confirming, this is not fixed by #4252 - this is a different problem

Yeah, it is a separate issue. It is resolved locally by handling both Maps and Arrays. This is the approach I took for quickest, least disruptive approach - BUT - I am including E2E tests to ensure the correct dialog IS actually shown. This way, once once the MAP vs ARRAY thing is resolved we will have e2e tests already in place to ensure it continues to work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working needs-triage Needs looking at to decide what to do size:S - 2 Sizing estimation point
Projects
Status: Closed / Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants