No device list paging

[Steve-Mcl]

Follow up to https://github.com/flowforge/security/issues/16

• Team Devices: Lack of paging causing device listing pages to slowdown when lots of devices exist
• Instance Devices: Lack of paging causing device listing pages to slowdown when lots of devices exist

Originally posted by @Steve-Mcl in https://github.com/flowforge/security/issues/16#issuecomment-1614867214

[MarianRaphael]

See also FlowFuse/forge-ui-components#101

[Pezmc]

From my research so far, this isn't as straighforward as it might seem on the surface:

• Both pages allow search and sort, search and sort is handled client side
• Adding pagination means search/sort needs to be handled server side always (or a hybrid approach)
• Paginated sorting & filtering forge-ui-components#101 is tracking the UI component changes to support this (and Table issues (Filtering, sorting and pagination) #1160 for FlowForge).

So to summarise; to be able add pagination to devices, we first need to implement server side search/sort functionality to ui-components, then forge itself.

@MarianRaphael I'm resizing this to large, how should this be prioritised compared to other work in this release? Is a quick fix, like breaking search/sort for devices with pages acceptable for now?

[MarianRaphael]

As discussed in the huddle:

1. Implement the "new" search/sort functionality (server side).
2. In the first iteration, use it only for the "Device List".
3. Add list paging for Devices

[MarianRaphael]

Not part of 1.11 - The plan is to merge it this afternoon (after the release) to main / staging to verify it and release it next week.

[Pezmc]

This is on staging since last week and will be released on the next production deploy (and as part of 1.11)

[MarianRaphael]

@Pezmc, I can't verify the described behavior on staging. See the screenshot below:

Any idea why this might be the case?

[Pezmc]

@MarianRaphael What are you expecting to see here? You only have 18 devices, so there's no need to paginate. The threshold is set at 100

[MarianRaphael]

Ah, okay. This is good to know! I thought the threshold is lower. All good in this case.

[Pezmc]

100 was set based on @Steve-Mcl's research in https://github.com/flowforge/security/issues/16#issuecomment-1614860247.

It can be easily tweaked down the line however!