Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pagination dependency for Device Status API #2113

Closed
joepavitt opened this issue May 10, 2023 · 1 comment
Closed

Remove pagination dependency for Device Status API #2113

joepavitt opened this issue May 10, 2023 · 1 comment
Assignees
@Pezmc
Labels
area:api Work on the platform API size:S - 2 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.

Comments

@joepavitt
Copy link
Contributor

Description

In this PR we shipped a new feature to visualise Device status, and apply filtering through that visualisation. Currently, it uses the existing /devices endpoint which has a page limit of 1000. Whilst we have no customers exceeding this for now, ideally this would be an unlimited view of the Devices owned by a Team, in order to provide a cleaner way of filtering such a number.

Currently, we are dependent upon the following parameters of a Device in order to render that chart:

  • id
  • .lastSeenAt
  • .lastSeenMs
  • .lastSeenSince - calculated within the UI's API service.
  • status

Epic/Story

#1937

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate
@joepavitt joepavitt added task A piece of work that isn't necessarily tied to a specific Epic or Story. size:S - 2 Sizing estimation point area:api Work on the platform API labels May 10, 2023
@joepavitt joepavitt mentioned this issue May 10, 2023
Closed
@Pezmc Pezmc self-assigned this Sep 15, 2023
@Pezmc
Copy link
Contributor

Pezmc commented Sep 15, 2023

This was completed as part of #2677 which introduced a query string param ?statusOnly=true, which always returns all devices in a team/instance/application and only the status and list seen stats for the device.

@Pezmc Pezmc closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pezmc Pezmc

Labels
area:api Work on the platform API size:S - 2 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
☁️ Product Planning
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pezmc @joepavitt