Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to choose if they want to use the applauncher-icons icon set or the Office icon set. #154

Closed
DrewNaylor opened this issue Nov 14, 2019 · 3 comments

Comments

@DrewNaylor
Copy link
Owner

This can be done by extracting the icons for the Office apps with this example code:

Private Sub ExtractAssociatedIconEx()
    Dim ico As Icon = Icon.ExtractAssociatedIcon("C:\WINDOWS\system32\notepad.exe")
    Me.Icon = ico

End Sub

This would need to be modified for getting application icons, though. Maybe this could be a function that returns the icon of the file passed into it.

Adding a tab to the Options window may be of use if it runs out on the Personalization tab after moving the statusbar thing to its own tab along with an option to hide the statusbar.

In the Options window area for this, maybe what could be listed is a dropdown button with at least three options:

  • applauncher-icons (default)
  • Icons extracted directly from Microsoft Office apps
  • Icon set from theme

MSDN page:
https://docs.microsoft.com/en-us/dotnet/api/system.drawing.icon.extractassociatedicon?view=netframework-4.6.1

@DrewNaylor
Copy link
Owner Author

Obviously, icon sets from themes won't be supported in the theme engine in TE1.03, but when it is an option (probably in TE2.0, which is the portable theme engine), it'll be added as an option.

If the user has to choose to use the portable theme engine instead of the builtin one, then the option to use the icon set from the theme will only be used if the portable theme engine is being used. If it's not being used, the applauncher-icons icon set will be used as a fallback.

In the case of an icon not being provided by the theme, the default icon from applauncher-icons will be used instead, or, if it's not available for an application in the case of app list customization being used (see #153), a generic icon will be provided. Maybe something that looks like an application? Or perhaps one using that "window" icon in the Query icon. That may work.

@DrewNaylor DrewNaylor modified the milestones: Version 3.3, Version 3.4 Nov 14, 2019
@DrewNaylor
Copy link
Owner Author

This was a good idea, but it'll take a lot more work to get properly-sized icons from EXE files if libraries aren't used. Removing from 3.4 milestone for now.

@DrewNaylor DrewNaylor removed this from the Version 3.4 milestone Nov 15, 2019
@DrewNaylor DrewNaylor added the possible future change Issues with this tag might be considered again in the future, but not right now. label Nov 15, 2019
@DrewNaylor
Copy link
Owner Author

Apparently doing this isn't ok by Microsoft's copyrights, anyway. Good thing this wasn't implemented.

@DrewNaylor DrewNaylor removed the possible future change Issues with this tag might be considered again in the future, but not right now. label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant