Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Requirements not being met but are still able to go through #367

Closed
arnhav opened this issue Apr 6, 2018 · 8 comments
Closed

Map Requirements not being met but are still able to go through #367

arnhav opened this issue Apr 6, 2018 · 8 comments

Comments

@arnhav
Copy link

arnhav commented Apr 6, 2018

Apologies for being a bother again, however I was testing the latest snapshot of the plugin and came across a peculiar issue. I am using the feeMoney requirement for entrance into a dungeon and when the player has the money it deducts the amount from the player and allows them through, however even without having the money required the ready sign allows the player through. Additionally, it seems that the timeToNextPlay is not working either. I have it set to 2 (2 hours) and it allows the player back in almost immediately. Thank you for your time!

@Sataniel98
Copy link
Member

I'd like to clarify that timeToNextPlay only stops the player from entering the dungeon when he finished it. If he leaves for example with /dxl leave, he can play again immediately. Is it possible that permissions allow the player to bypass the requirement?

@arnhav
Copy link
Author

arnhav commented Apr 7, 2018

Ah I see, the player was leaving before finishing the dungeon. Is it possible to change that requirement so that the timer begins as soon as you leave a dungeon regardless of whether or not you finished the dungeon?

@Sataniel98
Copy link
Member

Sataniel98 commented Apr 7, 2018

You are not the first one who asked that and it does make sense to me to prevent the players from having infinite tries to finish the dungeon without delay. But I'd like to keep a setting that allows delays only if the dungeon is finished correctly. I'd add a new game rule that allows delays after fails, but something like that is not a high priority task at the moment.

@arnhav
Copy link
Author

arnhav commented Apr 7, 2018

Alrighty, thank you. As for the feeMoney requirement? Any idea as to why that allows you through even though you don't have the money?

@Sataniel98
Copy link
Member

Not sure ATM. I'll try to reproduce and fix that within the next 24-36 hours.

@Sataniel98 Sataniel98 added this to the Beta 0.16 milestone Apr 8, 2018
@Sataniel98
Copy link
Member

I was indeed able to reproduce a few issues with requirements:

  • The level requirement doesn't work well with keepInventoryOnEnter
  • The permission node dxl.ignorerequirements allows players to start the game even if they don't fulfill the requirements. However, they are still demanded, which is confusing.

Is it possible that you tested this with the dxl.ignorerequirements permission node?

@arnhav
Copy link
Author

arnhav commented Apr 8, 2018

Ah yea, that was probably the case.... I didn't realize that I had the permission node. And I probably got confused by the messages in chat. Thank you.

@Sataniel98
Copy link
Member

@arnhav11

Ah I see, the player was leaving before finishing the dungeon. Is it possible to change that requirement so that the timer begins as soon as you leave a dungeon regardless of whether or not you finished the dungeon?

Has been added in build 598 now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants