ESLint reccomended no-async-promise-executor broken in example

[srcrip]

The rule no-async-promise-executor seems to be set in the recommended group in new versions of ESLint. This trips the following code in the example:

entry-server.js

  return new Promise(async (resolve, reject) => {
    const { app, router, apolloProvider } = await createApp({
      ssr: true
    });

I just disabled the rule in my project but I don't fully understand the implications of doing so, so if someone knows a way to fix this in the example I think that'd be great given that this is now a recommended rule.

[Radiergummi]

Well, the following variant would work correctly without breaking this rule, and its much clearer anyway:

export default async context => {
    const {
              app,
              router,
              store,
          } = await createApp();

    router.push( prepareUrlForRouting( context.url ) );

    return new Promise( ( resolve, reject ) => {
        router.onReady( () => {
            context.rendered = () => {
                // After all preFetch hooks are resolved, our store is now
                // filled with the state needed to render the app.
                // When we attach the state to the context, and the `template` option
                // is used for the renderer, the state will automatically be
                // serialized and injected into the HTML as `window.__INITIAL_STATE__`.
                context.state = store.state;

            };

            resolve( app );
        }, reject );
    } );
}